"Steve M. Robbins" <[EMAIL PROTECTED]> writes: > This allows extension builders to select either the default Python > version, or a specific version, without knowing the Boost > and GCC versions [2].
Yep; so far so good. > I'd like to ask about intended behaviour if a bad action is supplied. > Or if an unsupported python version is given. I chose to exit with an > error message and status 1. Now I'm a little worried that will break > some Python installs and generate the hate mail. What's the > recommended behaviour here? Good question. I'd favor exiting with non-zero status, per the proposed implementation; if you're really concerned about potential disruption, you can always add "|| true" to the prerm's invocation so that users can at least readily pull libboost-python-dev from their systems until you resolve the breakage. I do, however, see a couple of concrete issues with your script: > if [ "$1" = "-d" ]; then > debug=-d > shift > fi Shouldn't you fix that at build time à la $version? > rtupdate) rtupdate $1 ;; More critically, AFAICT you want to pass $2, not $1. -- Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org) http://www.mit.edu/~amu/ | http://stuff.mit.edu/cgi/finger/[EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
