Dear Dmitry, thank you very much for your feedback. Please bear with me and my probably basic questions. This is my first packaging effort in Debian.
On 14/02/14 11:18, Dmitry Shachnev wrote: > 1) python-csb should depend on python-numpy and python-scipy (and > python3-csb should depend on python3-numpy and python3-scipy). > These dependencies are specified in REQUIRES field in setup.py and, > as I understand, the package is mostly useless without these > dependencies. The tests also need numpy to succeed. I see your point. Right now, build-depends is set to: debhelper (>= 9),python-all,python3-all,python-epydoc,python-numpy,python-scipy,python-matplotlib And the test dependencies python-csb,python3-csb,python-unittest2,python-numpy I'm a bit confused about the dependencies and referencing to the source or binary packages, and whether they're missing from only the tests or also from the main package. Where should the references to the binary package python3-numpy and -scipy be added? > 2) In debian/tests/build, Makefile-style variables are used. I > think that was blindly copied from debian/rules, and not really > needed. > > Also, you use python instead of $python, so in fact the test is > ran three times for python2.7. > > I would write the command like this: > > for py in $(pyversions -i) $(py3versions -i); do PYTHONWARNINGS=d > $py test/app.py --generated-resources /tmp --verbosity 2 done > > Note that I also increased verbosity to get the more understandable > output in case of failures. Thank you very much for your suggestion. I've updated the code accordingly. > 3) One of the tests fails (at least with Python 2.7): 4) The tests > failures are ignored. When the test fails for python2.7, the next > tests are run. After I figure out the correct setup for the tests I'll try to reproduce 3) and 4), and will probably get back to you with more questions ;) > 5) Some test is printed into stderr, for example the deprecation > warnings and names of the tests. Autopkgtest considers that as a > failure by default, to allow stderr you need to add this line to > debian/tests/control: > > Restrictions: allow-stderr Is the addition of this restriction a good idea, or should I rather try to get upstream to change the behaviour? Once again, thank you for your detailed observations. They are extremely helpful. Cheers, Tomás -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/52fe2230.1030...@tdido.com.ar
