On Sun, 1 Mar 2026 23:00:41 +0900 yokota <[email protected]> wrote:
> Current packaging site is moved under python-team: > https://salsa.debian.org/python-team/packages/python-pykakasi hi Hiroshi, please find my review of pykakasi below. Some of the issues closely resemble those identified for jaconv, but are included anyway to keep things in one place. For the binary package, I used a private build of jaconv left over from yesterday's review of that package. * copyright: upstream uses GPL-3+ in both code headers and pyproject.toml, not GPL-3 (only). * copyright: please don't repack the orig tarball unless doing so is necessary; if you want things like egg-info out of the way there's less intrusive ways to achieve that (d/clean etc.). * copyright: no need to repeat the upstream claim itself within a license paragraph, these aren't part of the terms of the license. In similar fashion, the copyright fields in various places should be trimmed to just "Copyright: <year> <holder>", without any extras such as 'Copyright (C)' or 'all rights reserved'. * rules: hardening enabled for a pkg with nothing to harden? * rules: undefined variable $(TEST_ARGS) used in argument to dh call (args were passed by environment var PYBUILD_TEST_ARGS instead) * docs: installs sphinx documentation sources into the binary package without actually building the docs? * docs: files such as AUTHORS and CONTRIBUTE that don't seem to be useful as end user documentation. * lintian: W: python3-pykakasi: extended-description-line-too-long line 2 W: python3-pykakasi: no-manual-page [usr/bin/kakasi-pykakasi] W: python3-pykakasi: python-module-in-wrong-location usr/lib/python3.14/dist-packages/pykakasi -> usr/lib/python3/dist-packages/pykakasi The files triggering that last warning are the following (all duplicates of files also installed in /usr/lib/python3/dist-packages/pykakasi): drwxr-xr-x root/root 0 2025-12-29 15:45 ./usr/lib/python3.14/dist-packages/ drwxr-xr-x root/root 0 2025-12-29 15:45 ./usr/lib/python3.14/dist-packages/pykakasi/ drwxr-xr-x root/root 0 2025-12-29 15:45 ./usr/lib/python3.14/dist-packages/pykakasi/data/ -rw-r--r-- root/root 1252 2025-12-29 15:45 ./usr/lib/python3.14/dist-packages/pykakasi/data/halfkana3.db -rw-r--r-- root/root 6825 2025-12-29 15:45 ./usr/lib/python3.14/dist-packages/pykakasi/data/hepburndict3.db -rw-r--r-- root/root 3290 2025-12-29 15:45 ./usr/lib/python3.14/dist-packages/pykakasi/data/hepburnhira3.db -rw-r--r-- root/root 7507 2025-12-29 15:45 ./usr/lib/python3.14/dist-packages/pykakasi/data/itaijidict4.db -rw-r--r-- root/root 6827 2025-12-29 15:45 ./usr/lib/python3.14/dist-packages/pykakasi/data/kunreidict3.db -rw-r--r-- root/root 3273 2025-12-29 15:45 ./usr/lib/python3.14/dist-packages/pykakasi/data/kunreihira3.db -rw-r--r-- root/root 7735 2025-12-29 15:45 ./usr/lib/python3.14/dist-packages/pykakasi/data/passportdict3.db -rw-r--r-- root/root 3680 2025-12-29 15:45 ./usr/lib/python3.14/dist-packages/pykakasi/data/passporthira3.db I'm not sure what causes these files to be installed there; this might well be an issue with the tooling rather than the packaging.
pgp7LB5e7gwlY.pgp
Description: OpenPGP digital signature
