hi Aeliton, I reviewed the audio-visualizer-python package, up for sponsorship in the Python team:
* patches: 0003 seems to serve no other purpose than deleting a file.
You don't want to use patches for that. To prevent that license
file from getting installed, please use some other method with a
much smaller footprint, such as overriding dh_install to exclude
the file from install, or removing it after the install step in an
override_after_ stanza.
* rules: why is test_comp_spectrum_previewRender getting deselected?
I can see it failed on i386 on the CI, but there could be a number
of reasons for that. Was the cause for the failure investigated? Is
the test itself buggy or does it correctly identify a bug in
upstream code? Was the issue reported upstream?
Adding an explanatory comment alongside the relevant setting in
d/rules can be very helpful to provide a bit of context.
For reference, the relevant part of the CI log:
=================================== FAILURES
===================================
_______________________ test_comp_spectrum_previewRender
_______________________
coreWithSpectrumComp = Component(module 5, pos 0)
(<avp.components.spectrum.Component object at 0xed341260>)
Name: Spectrum v1
Preset: {'ampl...irror': False,
'mode': 0,
'mono': False,
'scale': 100,
'tc': 0.017,
'window': 0,
'x': 0.0,
'y': 0.0,
'zoom': 1}
def test_comp_spectrum_previewRender(coreWithSpectrumComp):
comp = coreWithSpectrumComp.selectedComponents[0]
image = comp.previewRender()
> assert imageDataSum(image) == 71992628
E assert np.int32(71993239) == 71992628
E + where np.int32(71993239) = imageDataSum(<PIL.Image.Image image
mode=RGBA size=1920x1080 at 0xED34CD20>)
tests/test_comp_spectrum.py:24: AssertionError
Once the above comments have been addressed, simply re-add the
package to the IRC channel topic and/or ping me by e-mail.
pgpCKo5c7DXXX.pgp
Description: OpenPGP digital signature
