hi Lester,

I took a look at the pydsinternals package, up for sponsorship in the
Python team:

* repo: the files on the pristine-tar branch still carry the old
  source package name, which causes tools such as 'origtargz' to fall
  back to uscan. Please refresh the branch so the filenames match the
  current source package name.

* control: the hard-coded python module deps on the binary package
  aren't needed, both would be auto-added by pybuild based on
  requirements.txt.

* control: there is a missing dependency though, for the cryptography
  module (which isn't listed in the upstream requirements file);
  unconditional import at:
  dsinternals/common/cryptography/X509Certificate2.py:14:from 
cryptography.hazmat.primitives.serialization import pkcs12, PrivateFormat
  dsinternals/common/cryptography/X509Certificate2.py:15:from 
cryptography.hazmat.primitives import hashes 

* CI: you could add support for testing the nocheck build profile;
  see python-asn1tools for an example salsa-ci.yml config.


Other than that, LGTM.

Once the above comments have been addressed, simply re-add the
package to the IRC channel topic and/or ping me by e-mail.

Attachment: pgps1TsileXN4.pgp
Description: OpenPGP digital signature

Reply via email to