Bug#382784: Missing package check for wallpaper-tray

[Neil Williams]

On 29/10/06 07:01:41, Simon Waters wrote:

A little searching suggests that this bug is due to a missing linker
option.

In particular in the src/Makefile the loader needs flags
"-Wl,-export-dynamic", as explained here;

The attached patch brings in the correct pkg-config rules.

I have rebuilt wallpaper-tray with the 0.5.1 tarball, and apart from

the "tarball" being named "wp_tray" rather than "wallpaper_tray", it is possible to recreate the debian package using the regular commands, but the same bug is still present.

... and the fact that all the files in the 0.4.6 tarball are executable which is quite odd (and unnecessary) ...

I assume that something should be placed in configure.in

[1] http://lists.debian.org/debian-devel-announce/2005/11/msg00016.html

[2]  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=391406


See also: http://rerun.lefant.net/checklib

--

Neil Williams
=============
http://www.data-freedom.org/
http://www.nosoftwarepatents.com/
http://www.linux.codehelp.co.uk/


--- wallpaper-tray-0.4.6.orig/configure.in
+++ wallpaper-tray-0.4.6/configure.in
@@ -12,7 +12,7 @@
 AM_PROG_CC_STDC
 AC_HEADER_STDC
 AM_PROG_LIBTOOL
-PKG_CHECK_MODULES(GNOME, libgnomeui-2.0 gtk+-2.0 libglade-2.0,,exit)
+PKG_CHECK_MODULES(GNOME, libgnomeui-2.0 gtk+-2.0 libglade-2.0 gmodule-2.0,,exit)
 AC_SUBST(GNOME_LIBS)
 AC_SUBST(GNOME_CFLAGS)
 dnl Checks for programs.

Yes. configure.in is incomplete. Actually, it is still incomplete after the patch but works because of indirect library dependencies [1]. wallpaper-tray has recently been adopted [2] after being orphaned, so hopefully these issues can be resolved by the new maintainer with upstream.

pgpOGWi6Oiq2P.pgp
Description: PGP signature