Your message dated Sun, 29 May 2022 21:15:56 +0000
with message-id <e1nvqgs-0004ux...@fasolo.debian.org>
and subject line Bug#763896: fixed in schroot 1.6.10-13
has caused the Debian Bug report #763896,
regarding schroot: infinite allocation on uid/gid entry errors.
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
763896: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=763896
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: schroot
Version: 1.6.10-1+b1
Severity: important
Tags: upstream patch

Hi!

The attached patch fixes an infinite allocation loop inside the
passwd::query_name, passwd::query_uid, group::query_gid and
group::query_name functions.

Current code simply fails with std::bad_alloc on any error,
because it always retries with a bigger buffer.


-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (150, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages schroot depends on:
ii  libboost-filesystem1.55.0       1.55.0+dfsg-3
ii  libboost-iostreams1.55.0        1.55.0+dfsg-3
ii  libboost-program-options1.55.0  1.55.0+dfsg-3
ii  libboost-regex1.55.0            1.55.0+dfsg-3
ii  libboost-system1.55.0           1.55.0+dfsg-3
ii  libc6                           2.19-11
ii  libgcc1                         1:4.9.1-16
ii  libpam0g                        1.1.8-3.1
ii  libstdc++6                      4.9.1-16
ii  libuuid1                        2.20.1-5.9
ii  schroot-common                  1.6.10-1

schroot recommends no packages.

Versions of packages schroot suggests:
pn  aufs-modules | unionfs-modules  <none>
pn  btrfs-tools                     <none>
ii  debootstrap                     1.0.63
ii  lvm2                            2.02.111-2
ii  qemu-user-static                2.1+dfsg-5

-- Configuration Files:
/etc/default/schroot changed [not included]
/etc/schroot/default/fstab changed [not included]
/etc/schroot/schroot.conf changed [not included]

-- no debconf information
Description: Fixes infinite allocation on error in name queries
 Don't retry with a bigger buffer if there is an error from name query
 calls is.
 This fixes error reporting in name queries.
Author: Daniel Serpell <daniel.serp...@aplik.cl>

--- schroot-1.6.10.orig/sbuild/sbuild-util.cc
+++ schroot-1.6.10/sbuild/sbuild-util.cc
@@ -632,7 +632,7 @@ sbuild::passwd::query_uid (uid_t uid)
 
   while ((error = getpwuid_r(uid, this,
                              &buffer[0], buffer.capacity(),
-                             &pwd_result)))
+                             &pwd_result)) == ERANGE)
     {
       size <<= 1;
       buffer.reserve(size);
@@ -655,7 +655,7 @@ sbuild::passwd::query_name (const char *
 
   while ((error = getpwnam_r(name, this,
                              &buffer[0], buffer.capacity(),
-                             &pwd_result)))
+                             &pwd_result)) == ERANGE)
     {
       size <<= 1;
       buffer.reserve(size);
@@ -741,7 +741,7 @@ sbuild::group::query_gid (gid_t gid)
 
   while ((error = getgrgid_r(gid, this,
                              &buffer[0], buffer.capacity(),
-                             &grp_result)))
+                             &grp_result)) == ERANGE)
     {
       size <<= 1;
       buffer.reserve(size);
@@ -764,7 +764,7 @@ sbuild::group::query_name (const char *n
 
   while ((error = getgrnam_r(name, this,
                              &buffer[0], buffer.capacity(),
-                             &grp_result)))
+                             &grp_result)) == ERANGE)
     {
       size <<= 1;
       buffer.reserve(size);

--- End Message ---
--- Begin Message ---
Source: schroot
Source-Version: 1.6.10-13
Done: Christoph Biedl <debian.a...@manchmal.in-ulm.de>

We believe that the bug you reported is fixed in the latest version of
schroot, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 763...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christoph Biedl <debian.a...@manchmal.in-ulm.de> (supplier of updated schroot 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 29 May 2022 18:11:18 +0200
Source: schroot
Architecture: source
Version: 1.6.10-13
Distribution: unstable
Urgency: low
Maintainer: Christoph Biedl <debian.a...@manchmal.in-ulm.de>
Changed-By: Christoph Biedl <debian.a...@manchmal.in-ulm.de>
Closes: 763896 900874
Changes:
 schroot (1.6.10-13) unstable; urgency=low
 .
   * Take maintainership. Closes: #900874
   * Streamline patch queue
   * Forward to latest commit in upstream repo, and refresh patches.
     Closes: #763896
Checksums-Sha1:
 8ee1dbff7408aab60743144fecb1193fe941e5e5 2226 schroot_1.6.10-13.dsc
 a0197a0c2a06d44a508d7eac95fd0ef784d81e5f 126952 schroot_1.6.10-13.debian.tar.xz
 7b7e3030559b0bfb5b0b8c716f5a68d046540534 9595 
schroot_1.6.10-13_powerpc.buildinfo
Checksums-Sha256:
 6ef06d6e6bce7bb6c8df32a6ab3e97f4d5c47bf33326f779e6a3ede70ac80983 2226 
schroot_1.6.10-13.dsc
 ac71529e34661a2292ed82af0e1ccc0e0858571dee10e5786de91e95ef9da778 126952 
schroot_1.6.10-13.debian.tar.xz
 19ed768ad295a28ede257897ad4baa5bab00f69f03652821a636fc2acb15374f 9595 
schroot_1.6.10-13_powerpc.buildinfo
Files:
 0c8670f69b9a5a2fffd623000014abff 2226 admin optional schroot_1.6.10-13.dsc
 ed386d5a9222fd52776856ac4c72a2bd 126952 admin optional 
schroot_1.6.10-13.debian.tar.xz
 b8358e0ea6801198176b83442d2ad3bf 9595 admin optional 
schroot_1.6.10-13_powerpc.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEWXMI+726A12MfJXdxCxY61kUkv0FAmKT3KkACgkQxCxY61kU
kv2xeQ//X71VCUsmZnUzwCzjCC2OdhFm8omr5V17JxFymD7cI9i+fEoRW12/FjBG
Gb6CSQoMs31YQWmvs2nrqPxV+NBNWMxwq+NprjNTdjCZ2sjIw/UXunLvzSvnojED
Uwffm0rqQ4ngo9gyHL/qmlljZv3C8r2UAB6OlKitNpj3yP7BS9+wyHGCgVhv/kJa
lqV4RQqSlfYKFnJ8UZqavnVazv2pGA6L1TJVkTAMOyR8Yp37X9lf3RmJ4c9Maa7U
GLOLpnVYLQg82n5WOnrsYvpkHbXCE06tiOqvi544GtQlaDTmj1/umJB3SPLNPNec
HAXg5/9OTHzSQ1WxRAQJpFTnP4UzYTvhTPTD43bNsiiXO4GZ5hrVg748JGRxklUj
xCcbsbPPXBj+8nGDgGlykTMhl23etnghp1Yge3mrcmz2f+pcLxi7CTKm4ZdRnAbE
85TQW/aLdoiIazDv84+2Mpj4C3H10fP0vZ3JuMg2fXIvN7Adh2yoaGeAlnNPWE8z
hs83jhWxfgs2Q/cpe5PZXnYMvO30w+jYH8Zjer4w14YX/1uHrXrN3B3CuAuf1rg6
xzzzLUtmP12GQR8z+Xz1eDUMgRpCcUBZ6AtTi6iKfE+Ot0xKoi1JgKERWojnv0qG
BUKX1JEGwAxZmSAM6iwRO7Ied7du4oelgObPN/1cgVQn1kCE0xI=
=1vv2
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to