Your message dated Tue, 24 Mar 2015 10:11:02 +0100
with message-id
<cagfehy0xfrtuqr24een_jmxxnknmh2dkgfo5sfg5penvtq1...@mail.gmail.com>
and subject line Re: Models: Refactor models to contain only ORM abstraction
has caused the Debian Bug report #762934,
regarding debsources: refactoring - move queries out of models.py
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
762934: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=762934
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: qa.debian.org
Severity: normal
User: qa.debian....@packages.debian.org
Usertags: debsources
models.py contains several classes which are used only by the web app and that
have nothing to do with the ORM layer, e.g. Location, Directory, SourceFile.
Similarly, models.py also contains static methods
(e.g. PackageName.list_versions_from_name) that should better be moved to a
query-specific module.
We should refactor the code so that models.py contains only the ORM
abstraction, and move query code to separate modules.
-- System Information:
Debian Release: jessie/sid
APT prefers testing
APT policy: (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.14-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
--- End Message ---
--- Begin Message ---
On Thu, 19 Mar 2015 10:58:30 +0100 Orestis Ioannou <ores...@oioannou.com> wrote:
> Since my last patch there was some discussion on how to better design this.
> In the end instead of just moving the queries out of the models it was
> decided to have 3 files:
>
> 1) models.py for the ORM layer
> 2) navigation.py for all the classes not in the ORM layer
> 3) queries.py for all the queries.
>
> Hence this patch implements this approach and refactors the two views.
Forgot to close this bug. Patch has been applied, thanks again Orestis!
Cheers,
--
Matthieu
--- End Message ---
