Ximin Luo:
> Package: qa.debian.org
> Severity: minor
> Tags: patch
> 
> Dear Maintainer,
> 
> Please see the attached patches, as well as the attached screenshot.
> 
> Note that the screenshot was produced by manually editing the DOM elements in
> Firefox, I did not get a chance to test out the patch yet. If they are buggy,
> the screenshot indicates "what was intended" so let me know and I'll fix it.
> 
> As comparison, this is what it looks like now:
> https://qa.debian.org/developer.php?login=infinity0&version=testing&bin=1
> 

I realised that my patch may break the "sorttable" functionality because 
everything is now combined into the same table.

However it can probably be fixed by making the javascript smarter, applying the 
sort only to the <tr> inside the implicit <tbody> directly after the <thead> 
that actually gets clicked. (And probably we should explicitly insert <tbody> 
in the source).

I'll add a new patch to fix this when I get some time, but in the meantime 
comments on the existing patches I attached would be appreciated.

X

-- 
GPG: ed25519/56034877E1F87C35
GPG: rsa4096/1318EFAC5FBBDBCE
https://github.com/infinity0/pubkeys.git

Reply via email to