On Sunday 21 February 2010 10:42:39 Eckhart Wörner wrote: > Hi Stefano, > > can you please test whether the patch at > https://bugs.kde.org/show_bug.cgi?id=227746#c2 works for you? > > Thank you! >
Hi, unfortunately, I wasn't able to apply the patch against the debian source (4:4.3.4-1). However, I tried to patch the file by hand (see attached file) and I successfully compiled it but it didn't solve the problem. I am not sure whether I may have done something wrong during the patching process or the patch is not effective against the bug. Thanks. PS I am going to post this message to the kdebugs bug too. -- Stefano Fortune of the day: "Living your life is a task so difficult, it has never been attempted before."
--- taskview.cpp 2010-02-22 15:54:15.000000000 -0500 +++ taskview.cpp.new 2010-02-22 16:50:15.000000000 -0500 @@ -963,40 +963,30 @@ void TaskView::deleteTask( Task* task ) +/* Attention when popping up a window asking for confirmation. +If you have "Track active applications" on, this window will create a new task and +make this task running and selected. */ { kDebug(5970) << "Entering function"; if (task == 0) task = currentItem(); if (currentItem() == 0) { KMessageBox::information(0,i18n("No task selected.")); - return; } - - int response = KMessageBox::Continue; - if (KTimeTrackerSettings::promptDelete()) - { - response = KMessageBox::warningContinueCancel( 0, - i18n( "Are you sure you want to delete the selected" - " task(s) and their entire history?\n" - "NOTE: all subtasks and their history will also " - "be deleted."), - i18n( "Deleting Task(s)"), KStandardGuiItem::del()); - } - - if (response == KMessageBox::Continue) + else { - int i=0; - QList<int> delendum; - while ( itemAt(i) ) + int response = KMessageBox::Continue; + if (KTimeTrackerSettings::promptDelete()) { - if ( itemAt( i )->isSelected()) - delendum << i; - i++; + response = KMessageBox::warningContinueCancel( 0, + i18n( "Are you sure you want to delete the selected" + " task(s) and their entire history?\n" + "NOTE: all subtasks and their history will also " + "be deleted."), + i18n( "Deleting Task(s)"), KStandardGuiItem::del()); } - for (int n=delendum.size()-1; n>=0; --n) - deleteTaskBatch(itemAt(delendum[n])); + if (response == KMessageBox::Continue) deleteTaskBatch(task); } - //d->mStorage->buildTaskView(this); } void TaskView::markTaskAsComplete()