2017-07-31 9:07 GMT+08:00 Boyuan Yang <073p...@gmail.com>: > 2017-07-31 9:04 GMT+08:00 Lisandro Damián Nicanor Pérez Meyer > <perezme...@gmail.com>: >> On sábado, 29 de julio de 2017 11:21:40 -03 Pino Toscano wrote: >>> Hi, >>> >>> I'm not uploading it myself, >> >> Neither me, but I wanted to add some more info to what Pino already provided. >> >>> but there are various things that ought to >>> be fixed: >>> >>> a) qtchooser is not needed in Build-Depends, it's an "implementation >>> detail" >> >> You might want to take a look at >> >> <http://pkg-kde.alioth.debian.org/packagingqtbasedstuff.html> >> >>> b) we don't use a "qtdeclarative5-" prefix for QML modules, but >>> "qml-module-" >> >> See <http://pkg-kde.alioth.debian.org/qmlmodulesnaming.html> >> >> >> >> -- >> Alas, I am dying beyond my means. >> Oscar Wilde, as he sipped champagne on his deathbed >> >> Lisandro Damián Nicanor Pérez Meyer >> http://perezmeyer.com.ar/ >> http://perezmeyer.blogspot.com/ > > Thank you all for the detailed review, which really helps. > > I'm not really familiar with C++/Qt/KDE packaging but this package > falls in this range as a dependency unfortunately. > I will read those instructions and fix problems. > > Regards, > Boyuan Yang
OK. All problems mentioned above should be fixed now, both in git repo and source package on mentors.debian.net. (Many thanks to pino@ and perezmeyer.) Future development and upstream maintenance is likely be taken by Deepin Co.,Ltd. if Canonical quits since Deepin software depends on this package heavily. Pkg-deepin team is working together with deepin upstream on it. As a result I believe n) should not be a blocker for package uploading. Package maintainer was set back to pkg-deepin since we are taking care of it in reality. Thanks for the suggestion. After enabling the test, this package would fail one test in Debian Unstable. Investigations show that it is a bug of Qt 5.7. [1][2] This bug has been fixed since Qt 5.8. Qt in Ubuntu already have this bug fixed by backporting upstream patch. With no visible time schedule for new Qt in Debian, I choose to disable that test for now and re-enable it after Qt 5.9 enters unstable. Meanwhile, anyone interested please consider reviewing the package again and help sponsor this package if you feel comfortable. This package is blocking the workflow of pkg-deepin team and it would be great if we could get the problem fixed in a reasonable time period. * https://anonscm.debian.org/git/collab-maint/gsettings-qt.git * https://mentors.debian.net/package/gsettings-qt [1] https://bugs.launchpad.net/ubuntu/+source/gsettings-qt/+bug/1624251 [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871265 Regards, Boyuan Yang
