Hi, I have done the changes and pushed into the repo. Please do review it.
Thanks, Sudheesh Shetty On Fri, Feb 12, 2016 at 11:36 AM, Balasankar C <[email protected]> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 > > Hi, > > On വെള്ളി 12 ഫെബ്രുവരി 2016 09:25 രാവിലെ, sudheesh shetty wrote: > > > I have done the required changes and added it to the repo. Please > > do review > > There are some stuff that I caught during the build > > 1. Use 3.9.7 as Standard Versions in debian/control as it is the latest. > 2. You've changed debian/compat to 9, but build-depends still mention > debhelper (>=7.0.50~) . Change that to >= 9.0 > 3. Quilt patch is missing a dep3 header. Refer the wiki[1] where it > mentions "Documenting the patch" . Not doing this makes lintian unhappy. > 4. If the executable in bin folder is actually not needed, consider > omitting it from installation (override dh_auto_install and add > statement to remove the bin directory from generated package directory > (i.e debian/ruby-diaspora-vines/usr/bin). This will solve some lintian > warnings. > 5. The package ships a conf directory (it contains certificates) that > it seems to used in the library. So, you will have to ship that > directory also (using install file in debian) to > /usr/share/ruby-diaspora-vines and patch the path to conf to match > that Debian specific path. Do ask Praveen about the existence of > another cert directory for diaspora, and whether it could be shared > with this package also. > > > [1] https://wiki.debian.org/Diaspora/Packaging/quilt > > - -- > Regards > Balasankar C > http://balasankarc.in > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > > iQEcBAEBCgAGBQJWvXZvAAoJEJbtq5sua3Fx0iUH/RNalnrt6r1bHTZMXNyDevVT > m7zhfjWNibUNkmUaiBtDInD4SDw5SHYpz/gDQNIbYi7DCDUKTBY/E+hVg2a8XHXL > at4pwrPXX1slWNEguuJxKr28en95FQ7XlW1u8BxbYeG3LwDngXAw6gV5WdSa5Gn3 > RB3jJC4J+P1LUDrv4gQ70XITLQ8Qiyhops5weR03HHpMZIq2RkfD/el6CluqNkCW > n9UVgVayRv17JmM9L2gf/hjFSkw99miEa3q5SgSWbz5MSJk2jFdf18jDVwT/mENR > gavrqfP7zoPZsPSMFAuNDlaXIUiuSRqp2EaatHGPeKL7rPKljJtywWncuN+Rzfs= > =BYOr > -----END PGP SIGNATURE----- >
