Your message dated Tue, 13 Sep 2022 21:33:55 +0000
with message-id <e1oydxx-0074bw...@fasolo.debian.org>
and subject line Bug#1019282: fixed in ignition-common 4.5.1+ds-2
has caused the Debian Bug report #1019282,
regarding ignition-common: missing header include, causes build failures of 
software using this lib
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1019282: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1019282
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: ignition-common
Version: 4.5.1+ds-1
Severity: serious
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu kinetic ubuntu-patch

Hi José Luis,

In Ubuntu, ignition-launch is failing to build from source because of an
error in an ignition-common header, Image.hh, which references memcpy() but
does not include string.h which declares it.

The attached patch to ignition-common fixes the build failure of
ignition-launch (not yet in Debian) and may help the buildability of other
software using ignition-common.

Thanks for considering,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slanga...@ubuntu.com                                     vor...@debian.org
diff -Nru ignition-common-4.5.1+ds/debian/control 
ignition-common-4.5.1+ds/debian/control
--- ignition-common-4.5.1+ds/debian/control     2022-07-19 05:53:51.000000000 
-0700
+++ ignition-common-4.5.1+ds/debian/control     2022-09-06 12:26:16.000000000 
-0700
@@ -1,6 +1,5 @@
 Source: ignition-common
-Maintainer: Ubuntu Developers <ubuntu-devel-disc...@lists.ubuntu.com>
-XSBC-Original-Maintainer: Debian Science Maintainers 
<debian-science-maintain...@lists.alioth.debian.org>
+Maintainer: Debian Science Maintainers 
<debian-science-maintain...@lists.alioth.debian.org>
 Uploaders: Jose Luis Rivero <jriv...@osrfoundation.org>
 Section: science
 Priority: optional
diff -Nru ignition-common-4.5.1+ds/debian/patches/missing-include.patch 
ignition-common-4.5.1+ds/debian/patches/missing-include.patch
--- ignition-common-4.5.1+ds/debian/patches/missing-include.patch       
1969-12-31 16:00:00.000000000 -0800
+++ ignition-common-4.5.1+ds/debian/patches/missing-include.patch       
2022-09-06 12:26:10.000000000 -0700
@@ -0,0 +1,18 @@
+Description: add missing include to header
+ Image.hh references memcpy() but doesn't include string.h which declares it.
+Author: Steve Langasek <steve.langa...@ubuntu.com>
+Last-Update: 2022-09-06
+Forwarded: no
+
+Index: ignition-common-4.5.1+ds/graphics/include/ignition/common/Image.hh
+===================================================================
+--- ignition-common-4.5.1+ds.orig/graphics/include/ignition/common/Image.hh
++++ ignition-common-4.5.1+ds/graphics/include/ignition/common/Image.hh
+@@ -21,6 +21,7 @@
+ #include <memory>
+ #include <string>
+ #include <vector>
++#include <string.h>
+ #include <ignition/math/Color.hh>
+ #include <ignition/common/graphics/Export.hh>
+ 
diff -Nru ignition-common-4.5.1+ds/debian/patches/series 
ignition-common-4.5.1+ds/debian/patches/series
--- ignition-common-4.5.1+ds/debian/patches/series      2022-06-27 
15:41:21.000000000 -0700
+++ ignition-common-4.5.1+ds/debian/patches/series      2022-09-06 
12:24:35.000000000 -0700
@@ -3,3 +3,4 @@
 0004-Disable-failing-tests-due-to-copyrighted-files.patch
 0005-Use-system-tinyobjloader.patch
 0003-Disable-performance-test.patch
+missing-include.patch

--- End Message ---
--- Begin Message ---
Source: ignition-common
Source-Version: 4.5.1+ds-2
Done: Jochen Sprickerhof <jspri...@debian.org>

We believe that the bug you reported is fixed in the latest version of
ignition-common, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1019...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jochen Sprickerhof <jspri...@debian.org> (supplier of updated ignition-common 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 13 Sep 2022 23:19:52 +0200
Source: ignition-common
Architecture: source
Version: 4.5.1+ds-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Maintainers 
<debian-science-maintain...@lists.alioth.debian.org>
Changed-By: Jochen Sprickerhof <jspri...@debian.org>
Closes: 1019282
Changes:
 ignition-common (4.5.1+ds-2) unstable; urgency=medium
 .
   * Team upload.
   * Add patch for missing include (Closes: #1019282)
Checksums-Sha1:
 9359998e2c785a4bbae26ac73b952c1c5499a660 3160 ignition-common_4.5.1+ds-2.dsc
 6c97203387b4fef90e8e8f9e59ef137bb1673a1a 14556 
ignition-common_4.5.1+ds-2.debian.tar.xz
 80ca6d53afe5726ec17a2c4570c125d3d64c7a0e 10135 
ignition-common_4.5.1+ds-2_source.buildinfo
Checksums-Sha256:
 25b79be7a992e8e8bd3edf26fc6aaccbca95a5e31568a40cd6cdb488a60b120c 3160 
ignition-common_4.5.1+ds-2.dsc
 5e227d36ac1b85f9d0f4ef632f24df808ca1f396efe3dbb0a7166d8c60ca59b6 14556 
ignition-common_4.5.1+ds-2.debian.tar.xz
 561fb4004ddfee9698962a1ad58a35cdf556e6c5f74608c646c27e9a562a12ab 10135 
ignition-common_4.5.1+ds-2_source.buildinfo
Files:
 1db09c34ac6c778f1fb65f7c8a59545c 3160 science optional 
ignition-common_4.5.1+ds-2.dsc
 1a4e2f8396d12fd90c79d6992f1984a2 14556 science optional 
ignition-common_4.5.1+ds-2.debian.tar.xz
 952ad821dd2db15ee68622993d04a9d5 10135 science optional 
ignition-common_4.5.1+ds-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEc7KZy9TurdzAF+h6W//cwljmlDMFAmMg9BwACgkQW//cwljm
lDO7qQ//Xxz+z7KP5ZlJF1P4QHF54klqaWc4QfpifqSu465RYo5FYV5W7U1igSoJ
HwBdyikmrxrVjqaI8zqgIuT9ACbK6clx/QAlFnDhkT1XH0/SztWDA1cvOCdgn0ng
q9QxFQhgjqsipeHq/e6kgl90PCP+f6UJvpyOAZl1MvMW709kJSVJ/JEMEm7ZCuGc
wKsXTXkgXwfbhEfWI34xxaGgg3fdoJ5EnAyIc9XDmbXQD45sePCOR7jy1c5bZaLD
KHO8opxrWvbyV8bjcYQ1KeTynW2oaNcqjULaf69+fGGVIqJi70/500eKFJiHD3N9
jQqFVx2VPziefBmWcgY+1VwQpjtipBIPFp+znIF0M7tnG1f4G4zogBheuOoHWiyX
1MQ3voDX2bLB6C4/n5m3dQj5pvvSP0rDc9Ye7hGWYcBNyFRk75abouqta6HIOZ3P
w5alZ14nNlPOz67fK5IhYONfvP1VYbpqiXKiFO6mWmhV8Cw/qHru4UT3jrSLvQFW
75OCgvACSIGKY4h5fW1lPzdPRd18yHu/Pod/4QFilUNI1A7vSzQuQa4oTccGhANd
YvV/zS9oqAlN2PkRLqI1HlgpoyqE46oKeg83OCXJ7KqmyQdOZbR1sYCah3G6ZpL5
ZdvkPh9bWNAI5lchVfo6mziNE1TA0bGTNA+jDiUMkkwb4bsbUkM=
=l+jI
-----END PGP SIGNATURE-----

--- End Message ---
-- 
debian-science-maintainers mailing list
debian-science-maintainers@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-science-maintainers

Reply via email to