On Saturday, April 05, 2014 13:07:09 Ole Streicher wrote:
> Control: tag -1 upstream
> Control: forwarded -1 https://github.com/astropy/astropy/issues/2171
>
> These problems are already forwarded to upstream. While the
> test_composite_static_matrix_transform failure could be fixed by
> increasing the tolerance, the checksum test failures would need to be
> silenced or disabled.
>
> However, I am afraid that the checksum test failure exposes a real
> problem that was not in the 0.3.0 version, so instead of just silencing
> it I will wait for a new version from upstream. See the upstream bug
> report for details.

According to the upstream report, the checksum tests should not be run on
non-64 bit architectures.  The attached patch accomplishes this and builds  on
i386.  python-astropy should be fixed before we make python3.4 the default
python3, so I would like to get this fixed.  I'm happy to NMU unless you'd
rather upload.

Let me know,

Scott K

diff -Nru python-astropy-0.3.1+dfsg/debian/changelog python-astropy-0.3.1+dfsg/debian/changelog
--- python-astropy-0.3.1+dfsg/debian/changelog	2014-03-06 05:55:09.000000000 -0500
+++ python-astropy-0.3.1+dfsg/debian/changelog	2014-05-03 15:32:29.000000000 -0400
@@ -1,3 +1,11 @@
+python-astropy (0.3.1+dfsg-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Add debian/patches/32bit_fix.patch to fix test failures on 32bit archs
+    Closes: #743554
+
+ -- Scott Kitterman <sc...@kitterman.com>  Sat, 03 May 2014 15:31:16 -0400
+
 python-astropy (0.3.1+dfsg-1) unstable; urgency=low

   * New upstream version
diff -Nru python-astropy-0.3.1+dfsg/debian/patches/32bit_fix.patch python-astropy-0.3.1+dfsg/debian/patches/32bit_fix.patch
--- python-astropy-0.3.1+dfsg/debian/patches/32bit_fix.patch	1969-12-31 19:00:00.000000000 -0500
+++ python-astropy-0.3.1+dfsg/debian/patches/32bit_fix.patch	2014-05-03 20:44:26.000000000 -0400
@@ -0,0 +1,22 @@
+Index: python-astropy-0.3.1+dfsg/astropy/io/fits/tests/test_checksum.py
+==================================================================+--- python-astropy-0.3.1+dfsg.orig/astropy/io/fits/tests/test_checksum.py	2014-03-04 12:47:45.000000000 -0500
++++ python-astropy-0.3.1+dfsg/astropy/io/fits/tests/test_checksum.py	2014-05-03 20:44:20.911914121 -0400
+@@ -49,7 +49,7 @@
+             assert 'CHECKSUM' in hdul[0].header
+             assert 'DATASUM' in hdul[0].header
+
+-            if not sys.platform.startswith('win32'):
++            if not (sys.platform.startswith('win32') or sys.maxsize < 2**31):
+                 assert hdul[0].header['CHECKSUM'] == 'ZHMkeGKjZGKjbGKj'
+                 assert hdul[0].header['DATASUM'] == '4950'
+
+@@ -62,7 +62,7 @@
+             assert 'CHECKSUM' in hdul[0].header
+             assert 'DATASUM' in hdul[0].header
+
+-            if not sys.platform.startswith('win32'):
++            if not (sys.platform.startswith('win32') or sys.maxsize < 2**31):
+                 assert hdul[0].header['CHECKSUM'] == 'jD4Am942jC48j948'
+                 assert hdul[0].header['DATASUM'] == '4164005614'
+
diff -Nru python-astropy-0.3.1+dfsg/debian/patches/series python-astropy-0.3.1+dfsg/debian/patches/series
--- python-astropy-0.3.1+dfsg/debian/patches/series	2014-03-06 05:55:09.000000000 -0500
+++ python-astropy-0.3.1+dfsg/debian/patches/series	2014-05-03 15:26:39.000000000 -0400
@@ -1,2 +1,3 @@
 mark_known_failures.patch
 python3.4.patch
+32bit_fix.patch

Attachment: signature.asc
Description: This is a digitally signed message part.

-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Reply via email to