Control: tags -1 patch

Hi,

On 14.05.2014 23:23, Moritz Muehlenhoff wrote:
ovito build-depends on libavcodec-dev and libavdevice-dev, but it's not linking
against any of them? Is the build dep obsolete? If so, please remove it.

These build-dependencies are not obsolete. The reason that ovito doesn't link against these libraries is a typo in debian/rules:
        -DOVITO_VIDEO_OUPUT_SUPPORT=ON \
                        ^
This should read:
        -DOVITO_VIDEO_OUTPUT_SUPPORT=ON \

Additionally a build-dependency on libswscale-dev is missing.

Attached patch fixes these problems.

There might also be problems with other configuration options:
CMake Warning:
  Manually-specified variables were not used by the project:

    OVITO_BUILD_PLUGIN_ATOMVIZ
    OVITO_BUILD_PLUGIN_POVRAY
    OVITO_BUILD_PLUGIN_STDOBJECTS

Best regards,
Andreas
diff --git a/debian/control b/debian/control
index 6aae6e4..b27c742 100644
--- a/debian/control
+++ b/debian/control
@@ -12,6 +12,7 @@ Build-Depends:
  docbook-xsl-doc-html,
  libavcodec-dev,
  libavdevice-dev,
+ libswscale-dev,
  libboost-dev,
  libboost-iostreams-dev,
  libboost-python-dev,
diff --git a/debian/rules b/debian/rules
index c407a0e..440f0cb 100755
--- a/debian/rules
+++ b/debian/rules
@@ -10,7 +10,7 @@ extra_flags += \
 	-DOVITO_BUILD_PLUGIN_SCRIPTING=TRUE \
 	-DOVITO_BUILD_PLUGIN_STDOBJECTS=TRUE \
 	-DOVITO_BUILD_PLUGIN_NETCDF=TRUE \
-	-DOVITO_VIDEO_OUPUT_SUPPORT=ON \
+	-DOVITO_VIDEO_OUTPUT_SUPPORT=ON \
 	-DOVITO_USE_SYSTEM_QCUSTOMPLOT=ON
 
 ifneq (,$(filter $(DEB_HOST_ARCH), kfreebsd-amd64 kfreebsd-i386 hurd-i386 powerpc))
-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Reply via email to