Your message dated Sat, 05 Dec 2015 23:43:51 +0000
with message-id <e1a5muz-0004vu...@franck.debian.org>
and subject line Bug#805534: fixed in qtiplot 0.9.8.9-11
has caused the Debian Bug report #805534,
regarding Potential stack overflow in Correlation.cpp
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
805534: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=805534
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: qtiplot
Version: 0.9.8.9-10

On systems that limit the stack space per user, the current implementation of
correlation causes a stack overflow for large tables, say 1e6 rows.  Otherwise
this amount of rows is handled well by Qtiplot.

The attached patch solves the problem, albeit you may want to implement
it differently.

Upstream (www.qtiplot.com) does not accept patches anymore

--- qtiplot-0.9.8.9/qtiplot/src/analysis/Correlation.cpp        2015-11-04 
11:36:44.139928471 +0100
+++ qtiplot-0.9.8.9/qtiplot/src/analysis/Correlation.cpp        2015-11-04 
11:44:03.501165132 +0100
@@ -150,21 +150,22 @@
 
     if (d_n > d_table->numRows())
         d_table->setNumRows(d_n);
 
        int cols = d_table->numCols();
        int cols2 = cols+1;
        d_table->addCol();
        d_table->addCol();
        int n = d_n/2;
 
-    double x_temp[d_n], y_temp[d_n];
+       double *x_temp = new double[d_n];
+       double *y_temp = new double[d_n];
        for (int i = 0; i<d_n; i++){
            double x = i - n;
         x_temp[i] = x;
 
         double y;
         if(i < n)
                        y = d_x[n + i];
                else
                        y = d_x[i - n];
         y_temp[i] = y;
@@ -185,11 +186,13 @@
        if (d_graphics_display){
                if (!d_output_graph)
                        createOutputGraph();
 
        DataCurve *c = new DataCurve(d_table, d_table->colName(cols), 
d_table->colName(cols2));
                c->setData(x_temp, y_temp, d_n);
                c->setPen(QPen(d_curveColor, 1));
                d_output_graph->insertPlotItem(c, Graph::Line);
                d_output_graph->updatePlot();
        }
+       delete[] x_temp;
+       delete[] y_temp;
 }

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message ---
Source: qtiplot
Source-Version: 0.9.8.9-11

We believe that the bug you reported is fixed in the latest version of
qtiplot, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 805...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Anton Gladky <gl...@debian.org> (supplier of updated qtiplot package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 06 Dec 2015 00:07:21 +0100
Source: qtiplot
Binary: qtiplot qtiplot-doc
Architecture: source
Version: 0.9.8.9-11
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Team 
<debian-science-maintainers@lists.alioth.debian.org>
Changed-By: Anton Gladky <gl...@debian.org>
Description:
 qtiplot    - data analysis and scientific plotting
 qtiplot-doc - data analysis and scientific plotting (documentation)
Closes: 804586 805534 805841 806871
Changes:
 qtiplot (0.9.8.9-11) unstable; urgency=medium
 .
   [ Damir Islamov ]
   * [846688b] Fix compilation with GSL2. (Closes: #805841)
 .
   [ Mirko Scholz ]
   * [fc32fcf] Fix stack overflow in Correlation.cpp. (Closes: #805534)
 .
   [ Anton Gladky ]
   * [9e62e36] Disable building of manual_en.pdf. (Closes: #804586, #806871)
   * [4fb51fd] Respect all versions of GSL.
Checksums-Sha1:
 a068259261ef84eb9ab6c84de3cfd033ae7c17c1 2532 qtiplot_0.9.8.9-11.dsc
 1fbd098b35b8bbe97361ac6f4627a11053296778 19988 qtiplot_0.9.8.9-11.debian.tar.xz
Checksums-Sha256:
 91fbbf01639a25d06ac219b7f8b83c979365d3757fdab0ef94e425769b7c69f2 2532 
qtiplot_0.9.8.9-11.dsc
 0d8c4d3b2d836381abed2e200cbba8ec15c4036b15ab586226095bf6b0124ffc 19988 
qtiplot_0.9.8.9-11.debian.tar.xz
Files:
 0bd2be10dbb5e04fc1b6d5c8ac215481 2532 math optional qtiplot_0.9.8.9-11.dsc
 cf3f2c6702b05bea5d08dd4d27749b15 19988 math optional 
qtiplot_0.9.8.9-11.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJWY26JAAoJENPhc4PPp/8Gjd4P/0ReKV1cYwijDto8UQSvlCah
AeZvYvziGnZnzJy0rhbDjYzjH/9s+9ogtpqCSBBOoV0Xc7isd7vrji7aEoVwf42m
5lCs1UZ4uehM5xwdtuHQsvkJN+QnSed2IVHyQjTwtj70BQTd241PEa1Q/Y1ps60B
29MYpJzsis0ayyidQs6eiqSdeMCD29q0osgdaWhWMz78XqjeSFt2w3/iCXLCXKjj
FGWn+Z0IxS22MMegRaPILzcCgfAZ3ugzvbG9abSBHmvEqXxEtINBaIM8YyBsDUrv
zw9QEXFv4nhmfHjqCMQvoNnBFVk1PDKvSIq7MaamsXMohre9/HaB5lKusiZROWrq
iVSvDRaI6XFQBgeN1ZwsDSoNXGxj8mxwFx5esqrkvRVRcXIvR48Kx4SibTt2xUj6
R8OLjhejlAOxb8EUqhSkbIbxqrunBokr3U2foiY9+YomFNPAYUGU++tdqfPhZ8L4
Vp2AgFeMjDndzpSaqJkW2OjyW4f6hWNgtQFbqcC0vYskaE7KWUYGWjhVKjuSI4Tf
MMY3GxI0Nl7WBLfTdIiuVLBQMmR0BFwdrACL2maFHzIjNeAInRtu2oNmMTFBezlQ
TUZnThRIgM93wRtaHxxSNkksx6RBZUs0phWfXolop7kyeZOfqjHyKuaVqWbuNkG5
me18BBz2trjxC220oq9X
=T1VQ
-----END PGP SIGNATURE-----

--- End Message ---
-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Reply via email to