Hi Marko,

the package looks fine, but I have a couple of notice:

- Use DEP-3 format for the patch
- Try not to use source/lintian-overrides, but fix it in the code.
- lib/extlib-abc/aig/cnf/cnfData.c looks strange, is it some kind
  of binary, not the source code?
- Use Files-Exclude parameter in d/copyright to drop PDF-files and
  generate dfsg-version of package.
- Apply "cme fix dpkg" to fix parameters formatting
- Use desktop-file instead of menu-file [1]:
- What is "outfile"?
- Clean d/rules from some comments, which are not relevant
- stp.install:
   - Remove debian/tmp, use just usr/bin usr/include etc.
   - Do not use versions in libs, use instead usr/lib/libstp.so.*
   - Think, whether you really need static lib (libstp.a)
   - Use multiarch path (GNUInstallDirs does it perfectly for cmake)
   - Think about splitting stp onto: stp, libstp2.1 and libstp-dev
(not mandatory)
- Please use VCS on git.debian.org
- Fix control-file according to debian-science policy
- Please double-check all files and their licenses. Everything should be
  documented in d/copyright.

Feel free to ask me, if you have some questions regarding those
notes. You have done a great job, please fix those notices and
I will upload the package (Afif, if you want, feel free to do it).

[1] https://lists.debian.org/debian-devel-announce/2015/09/msg00000.html
"We further resolve that "menu programs" should not depend on the
 Debian Menu System and should instead rely on .desktop file
 contents for constructing a list of applications to present to
 the user."

Best regards

Anton


2016-02-22 3:27 GMT+01:00 Marko Dimjašević <ma...@dimjasevic.net>:
> Dear all,
>
> Let me know if I can do something to get you interested in sponsoring
> this package for the Simple theorem prover. I am desperately looking for
> a sponsor. The package has been in the New queue before. Its details are
> given below. The package is also available on Alioth:
>
> git.debian.org/git/debian-science/packages/stp.git
>
>
> --
> Regards,
> Marko Dimjašević <ma...@cs.utah.edu> .   University of Utah
> https://dimjasevic.net/marko         . PGP key ID: 1503F0AA
> Learn email self-defense!  https://emailselfdefense.fsf.org
>
>
> On Sat, 2016-02-13 at 17:41 -0700, Marko Dimjašević wrote:
>> Package: sponsorship-requests
>> Severity: wishlist
>>
>> Dear mentors,
>>
>> I am looking for a sponsor for my package "stp"
>>
>> * Package name    : stp
>>   Version         : 2.1.2+dfsg-1
>>   Upstream Author : STP developers
>> * URL             : https://stp.github.io/
>> * License         : Expat and others
>>   Section         : science
>>
>> It builds those binary packages:
>>
>>   python-stp - Simple theorem prover library bindgings for Python
>>   stp - Simple theorem prover
>>
>> To access further information about this package, please visit the
>> following URL:
>>
>>   http://mentors.debian.net/package/stp
>>
>>
>> Alternatively, one can download the package with dget using this
>> command:
>>
>>   dget -x http://mentors.debian.net/debian/pool/main/s/stp/stp_2.1.2
>> +dfsg-1.dsc
>>
>> More information about STP can be obtained from https://stp.github.io/.
>>
>> Changes since the last upload:
>>
>>   - new upstream release
>>   - added copyright for the OutputCheck archive per Thorsten Alteholz's
>> instructions (ftp-master)
>>
>>
>
>
> --
> debian-science-maintainers mailing list
> debian-science-maintainers@lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Reply via email to