Package: dune-functions
Version: 2.4~20160406ge6b3b4c-1
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu yakkety ubuntu-patch

Dear Maintainer,

dune-functions FTBFS in Ubuntu because we switched to glibc 2.23, which
apparently changed the behavior of std::accumulate, as you can see here:
https://launchpadlibrarian.net/257938061/buildlog_ubuntu-yakkety-amd64.dune-functions_2.4~20160406ge6b3b4c-1_BUILDING.txt.gz

The documentation for std::accumulate says to include the <numeric> header,
and that fixed the build.

This will have to be bumped to serious importance once glibc 2.23 is in
unstable - better to fix it beforehand!

In Ubuntu, the attached patch was applied to achieve the following:

  * debian/patches/std-accumulate.patch: Include <numeric> in files that use
    std::accumulate to fix FTBFS with glibc 2.23.

Thanks for considering the patch.

Logan Rosen

-- System Information:
Debian Release: stretch/sid
  APT prefers xenial-updates
  APT policy: (500, 'xenial-updates'), (500, 'xenial-security'), (500, 
'xenial'), (100, 'xenial-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.4.0-21-generic (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL 
set to en_US.utf8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru dune-functions-2.4~20160406ge6b3b4c/debian/patches/series dune-functions-2.4~20160406ge6b3b4c/debian/patches/series
--- dune-functions-2.4~20160406ge6b3b4c/debian/patches/series	2016-04-08 04:13:24.000000000 -0400
+++ dune-functions-2.4~20160406ge6b3b4c/debian/patches/series	2016-05-05 02:53:32.000000000 -0400
@@ -1 +1,2 @@
 skip-hybrid-tests.patch
+std-accumulate.patch
diff -Nru dune-functions-2.4~20160406ge6b3b4c/debian/patches/std-accumulate.patch dune-functions-2.4~20160406ge6b3b4c/debian/patches/std-accumulate.patch
--- dune-functions-2.4~20160406ge6b3b4c/debian/patches/std-accumulate.patch	1969-12-31 19:00:00.000000000 -0500
+++ dune-functions-2.4~20160406ge6b3b4c/debian/patches/std-accumulate.patch	2016-05-05 02:56:42.000000000 -0400
@@ -0,0 +1,25 @@
+Index: dune-functions-2.4~20160406ge6b3b4c/dune/functions/functionspacebases/bsplinebasis.hh
+===================================================================
+--- dune-functions-2.4~20160406ge6b3b4c.orig/dune/functions/functionspacebases/bsplinebasis.hh
++++ dune-functions-2.4~20160406ge6b3b4c/dune/functions/functionspacebases/bsplinebasis.hh
+@@ -5,6 +5,8 @@
+  * \brief The B-spline global function space basis
+  */
+ 
++#include <numeric>
++
+ /** \todo Don't use this matrix */
+ #include <dune/common/dynmatrix.hh>
+ 
+Index: dune-functions-2.4~20160406ge6b3b4c/dune/functions/functionspacebases/test/gridviewfunctionspacebasistest.cc
+===================================================================
+--- dune-functions-2.4~20160406ge6b3b4c.orig/dune/functions/functionspacebases/test/gridviewfunctionspacebasistest.cc
++++ dune-functions-2.4~20160406ge6b3b4c/dune/functions/functionspacebases/test/gridviewfunctionspacebasistest.cc
+@@ -3,6 +3,7 @@
+ #include <config.h>
+ 
+ #include <iostream>
++#include <numeric>
+ 
+ #include <dune/common/exceptions.hh>
+ #include <dune/common/typetraits.hh>
-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Reply via email to