Your message dated Mon, 03 Apr 2017 19:19:01 +0000
with message-id <e1cv7vf-0008mc...@fasolo.debian.org>
and subject line Bug#847925: fixed in maxima-sage 5.39.0+ds-1
has caused the Debian Bug report #847925,
regarding maxima-sage: build does not handle multiple LDFLAGS
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
847925: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=847925
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: maxima-sage
Version: 5.35.1-1

Hi Maintainer

Building maxima-sage with LDFLAGS containing more than one flag results in warnings similar to the following:

;      - Loading binary file "binary-ecl/init-cl.fas"
;;; Loading "/<<PKGBUILDDIR>>/src/binary-ecl/init-cl.fas"
;  - Providing system maxima
/usr/bin/ld: warning: -z relro -Wl ignored.
/usr/bin/ld: warning: -z now -Wl ignored.
/usr/bin/ld: warning: -z relro -Wl ignored.
/usr/bin/ld: warning: -z now -Wl ignored.

To reproduce, add either or both of the following lines to debian/rules:

export DEB_LDFLAGS_MAINT_APPEND=-Wl,--as-needed
export DEB_BUILD_MAINT_OPTIONS=hardening=+all

In Ubuntu, the build fails with an error instead of a warning:

; - Loading binary file "binary-ecl/init-cl.fas"
;;; Loading "/<<PKGBUILDDIR>>/src/binary-ecl/init-cl.fas"
;  - Providing system maxima
/usr/bin/ld: unrecognized option '-Bsymbolic-functions -Wl'
/usr/bin/ld: use the --help option for usage information
collect2: error: ld returned 1 exit status
An error occurred during initialization:
Error code 1 when executing
(RUN-PROGRAM "gcc" ("-o" "binary-ecl/maxima.fas" "-L/usr/lib/"
                    "/tmp/eclinitH7b3lL.o" "binary-ecl/maxima-package.o"
"binary-ecl/ecl-port.o" "binary-ecl/autoconf-variables.o"
                    ...
                    "binary-ecl/init-cl.o"
"-Wl,-Bsymbolic-functions -Wl,-z,relro" "-shared" "-lecl"
                    "-lgmp" "-lgc" "-lffi" "-lpthread" "-ldl" "-lm")).
Makefile:1253: recipe for target 'binary-ecl/maxima' failed

The attached patch clears the warnings and errors, but I am no lisp programmer. The split-string function was copied straight from lisp-utils/defsystem-lisp.

Regards
Graham

--- a/src/maxima.system
+++ b/src/maxima.system
@@ -59,6 +59,19 @@
     (and (apply #'compile-file file :output-file object-output args)
 	 (c:build-fasl output :lisp-files (list object-output)))))
 
+(defun split-string (string &key (item #\space) (test #'char=))
+  ;; Splits the string into substrings at spaces.
+  (let ((len (length string))
+	(index 0) result)
+    (dotimes (i len
+		(progn (unless (= index len)
+			 (push (subseq string index) result))
+		       (reverse result)))
+      (when (funcall test (char string i) item)
+	(unless (= index i);; two spaces in a row
+	  (push (subseq string index i) result))
+	(setf index (1+ i))))))
+
 #+ecl
 (defun build-maxima-lib ()
   (labels ((list-all-objects (module)
@@ -80,12 +93,12 @@
 			  :ld-flags
 			  (let ((x (symbol-value (find-symbol "*AUTOCONF-LD-FLAGS*"
 							      (find-package "MAXIMA")))))
-			    (if (and x (not (string= x ""))) (list x))))
+			    (if (and x (not (string= x ""))) (split-string x))))
 	(c::build-program "binary-ecl/maxima" :lisp-files obj
 			  :ld-flags
 			  (let ((x (symbol-value (find-symbol "*AUTOCONF-LD-FLAGS*"
 							      (find-package "MAXIMA")))))
-			    (if (and x (not (string= x ""))) (list x)))
+			    (if (and x (not (string= x ""))) (split-string x)))
 			  :epilogue-code '(progn (require :defsystem)
 					         (cl-user::run)))))))
 

--- End Message ---
--- Begin Message ---
Source: maxima-sage
Source-Version: 5.39.0+ds-1

We believe that the bug you reported is fixed in the latest version of
maxima-sage, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 847...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Tobias Hansen <than...@debian.org> (supplier of updated maxima-sage package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 03 Apr 2017 19:53:07 +0100
Source: maxima-sage
Binary: maxima-sage maxima-sage-doc maxima-sage-share
Architecture: source
Version: 5.39.0+ds-1
Distribution: experimental
Urgency: medium
Maintainer: Debian Science Team 
<debian-science-maintainers@lists.alioth.debian.org>
Changed-By: Tobias Hansen <than...@debian.org>
Description:
 maxima-sage - Computer algebra system -- base system
 maxima-sage-doc - Computer algebra system -- documentation
 maxima-sage-share - Computer algebra system -- extra code
Closes: 847925
Changes:
 maxima-sage (5.39.0+ds-1) experimental; urgency=medium
 .
   * New upstream version.
   * Remove stdin-illegal-seek.patch (applied upstream).
   * Apply handle-multiple-ldflags.patch. (Closes: #847925)
   * Install data files to /usr/share/maxima-sage instead of /usr/share/maxima
     using new patch change_name_to_maxima-sage.patch.
   * Repack source to get rid of dos line endings conflicting with git.
Checksums-Sha1:
 0be4860adb37789b249b735a7988b1f7efda5a91 2246 maxima-sage_5.39.0+ds-1.dsc
 0fd0aba7dce203cdb69dd7563267003935311451 28648352 
maxima-sage_5.39.0+ds.orig.tar.xz
 3e8d48f9f9df96480d14c90d87487dce6047c1ab 17580 
maxima-sage_5.39.0+ds-1.debian.tar.xz
 a15da63cbbd8150c2cecfeaac5a0652863f488c5 8285 
maxima-sage_5.39.0+ds-1_source.buildinfo
Checksums-Sha256:
 21b101597e428453fc6d736c1a69d449265be5a82f1a48ad56fae96c56d62a18 2246 
maxima-sage_5.39.0+ds-1.dsc
 ff97926cdea5893e811777040d60a5568f87e4bd2c04cf139775581911be9591 28648352 
maxima-sage_5.39.0+ds.orig.tar.xz
 0622038f2341f36564154215e1f59631d8ae82e3db9f97e36d7ebf4dbf7dc126 17580 
maxima-sage_5.39.0+ds-1.debian.tar.xz
 fcdf1fcde3bcb075451a9ac48b18e6df73cf916d9076eec5dfab0880e21733aa 8285 
maxima-sage_5.39.0+ds-1_source.buildinfo
Files:
 d312981eaa1a36cb27dd9e978b3a0672 2246 math optional maxima-sage_5.39.0+ds-1.dsc
 826674338cc64bfad900919a6e817db5 28648352 math optional 
maxima-sage_5.39.0+ds.orig.tar.xz
 758f4c56109f918ce9b7d877cbc43d8a 17580 math optional 
maxima-sage_5.39.0+ds-1.debian.tar.xz
 3c2fb1728fe47fe68285075591c8c5d2 8285 math optional 
maxima-sage_5.39.0+ds-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoH46ol3M2u2mYo0kjIIWnY7OzSoFAljimu4ACgkQjIIWnY7O
zSpuIA/+LJdAkxveI/1z2R49+xClpKRMJdagmkkW5MuiuQDFQIjMt3Qpscc+PVov
z00aTyj8JgyfglTrawz/iOvOKB2TxAJxkv1VjwlCGWUvBsYwsa09krSmp0GMdW6l
5eV5/Ko+47aiRTeqo7dtjYZGdkgNtpb85lamPGBdTT8UjF8NM44DCG7yEHYhYp8i
CKRZiCIoD20cAbO/9gxnqgpcobax98PiANWpER70spae5TwTF2cEBfcvtLKol14d
bwCTU4s3sItiSnOSO89LSqo3d0FR0kW4X83tCnxgwzOomt88ndG24w8Un25FO8BS
+w6zp50c2pocLqvVizt17HDj3wzOwQe9G4+Gv21S4w31c2PuFeJWXC10j2+EBG4y
wgelJwV7fkq1drCn2DC719+IO8fZUbt2Ogw2Q7FzemUdu0YRyfwN2kqGaq0f8riK
6OzOQD3FsWElXxqzlC8Xtg/Yu02oJToERkbIjDa4AGu9VNe+Y/pE/pFnVXE8H7Ph
rMmHtRHNQ3MhHs08XiyRdIpxO2IbogHeLmomr85slC7iTQ6AvHotrQL4Etk3S50v
qoHeSregMMxnNFE/rjfqOFdBYmis4/jObxh0N60skRQlYcTBGaS+zgjJQcuTeulv
WUg64kD2VMAyG5pqo7uc0QL10JI9yIIanMLaXIQsSoaHwX9Fesg=
=5O5u
-----END PGP SIGNATURE-----

--- End Message ---
-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Reply via email to