Your message dated Mon, 15 May 2017 12:48:57 +0000 with message-id <e1dafqn-000edx...@fasolo.debian.org> and subject line Bug#862595: fixed in reprozip 1.0.9-4 has caused the Debian Bug report #862595, regarding FTBFS with python3.6 to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 862595: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=862595 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Source: reprozip Version: 1.0.9-2 Tags: upstream patch Hi, Currently reprozip FTBFS in Ubuntu[1], which has switched to python3.6. The failure is in the test suite: > ====================================================================== > ERROR: test_combine (test_reprozip.TestCombine) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/<<PKGBUILDDIR>>/debian/tests/test_reprozip.py", line 403, in > test_combine > traceutils.combine_traces(traces, target) > File > "/<<PKGBUILDDIR>>/.pybuild/pythonX.Y_3.6/build/reprozip/traceutils.py", line > 237, in combine_traces > ''') > sqlite3.OperationalError: cannot DETACH database within transaction Looking at the source, reprozip does a series of inserts and deletes followed by a detach for a list of databases[2]. However, python3.6's sqlite3 module no longer implicitly commits an open transaction[3] (and an implicit transaction has been begun in this case), so the DETACH fails. I have included a patch which fixes this (tested with an artful + artful-proposed chroot, as well as unstable to check for regressions). I see there's another conn.commit right after the final DETACH; maybe that can go now, though it's probably not doing any harm... Regards, James [1] https://launchpadlibrarian.net/319561506/buildlog_ubuntu-artful-amd64.reprozip_1.0.9-2_BUILDING.txt.gz [2] https://sources.debian.net/src/reprozip/1.0.9-2/reprozip/traceutils.py/#L234 and #L239 [3] https://docs.python.org/3/whatsnew/3.6.html --- a/reprozip/traceutils.py +++ b/reprozip/traceutils.py @@ -230,12 +230,20 @@ def combine_traces(traces, target): DELETE FROM maps.map_processes; ''') + # An implicit transaction gets created. Python used to implicitly + # commit it, but no longer does as of 3.6, so we have to explicitly + # commit before detaching. + conn.commit() + # Detach conn.execute( ''' DETACH DATABASE trace; ''') + # See above. + conn.commit() + conn.execute( ''' DETACH DATABASE maps;
--- End Message ---
--- Begin Message ---Source: reprozip Source-Version: 1.0.9-4 We believe that the bug you reported is fixed in the latest version of reprozip, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 862...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Ghislain Antony Vaillant <ghisv...@gmail.com> (supplier of updated reprozip package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Mon, 15 May 2017 09:40:48 +0100 Source: reprozip Binary: reprozip python3-reprozip python3-reprozip-dbg Architecture: source Version: 1.0.9-4 Distribution: unstable Urgency: medium Maintainer: Debian Science Maintainers <debian-science-maintainers@lists.alioth.debian.org> Changed-By: Ghislain Antony Vaillant <ghisv...@gmail.com> Description: python3-reprozip - modules for the ReproZip packer python3-reprozip-dbg - debug extensions for the ReproZip packer reprozip - tool for reproducing scientific experiments (packer) Closes: 862585 862595 Changes: reprozip (1.0.9-4) unstable; urgency=medium . * Enable build for x32. Thanks to James Clarke for reporting (Closes: #862585) * Fix FTBFS with Python 3.6 - New patch Commit-sqlite3-transactions-explicitly.patch Thanks to James Clarke for the patch (Closes: #862595) Checksums-Sha1: db641fc1abd51fd2cabfcfac637eb9663ac9f665 2285 reprozip_1.0.9-4.dsc 514ddc17737bdaf33dea1aeb9041fd22245cf2e2 6620 reprozip_1.0.9-4.debian.tar.xz Checksums-Sha256: a98761ddb080b490514dc405829a9d33558de974c7ebf8238894a4383fbbca64 2285 reprozip_1.0.9-4.dsc 69918bf1ddf8027450c69ba40474fbc1142243d61dd8b81abd7b3abd52535d4d 6620 reprozip_1.0.9-4.debian.tar.xz Files: 183d1e3c07f2e7f2f89852abf4c3257f 2285 science optional reprozip_1.0.9-4.dsc d1812f8dcc30f46d4fc41d59bfd55e88 6620 science optional reprozip_1.0.9-4.debian.tar.xz -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZGZ9SAAoJEPNPCXROn13ZoC8P/AukLTnxvx9GRoSDY0xXm+ro H9QHHoHGElJZs1ZjcXhAT9pPmXZEmxPludjdqdPbu2oNr3scguDWR23zwmM+xUm7 ASTpU4JvcjKaGBHKdanReGjxZhUP+5ZH2vjDFJTg/1sNRSELuOWHevUyjlNSKDGH vt+YFFJ13vWx6QjGh0gAOLVTgdva/JUbz121WQMmdqzjUi2tS7zXk6gVa9lBVdnE R8miKZN3phbLJOP09yF5VoPha+Q9dfa+3Es5w/1DeqK0EXK9TWyxeSBoqYi1+VFD a3tuhayDKflKj0g/kgIEO0naHRKrsSdHyKtNqILCs6+Ru8erpSUQJyn3guRLNHI5 KxqORYvcGyzife1duswZ7tMicwYHK0G3wq+fxQa+h2tvDDmTcAgt4SNiDEGBv5Ev 3s4kBamvSD/grK3ghPJQRL23dgMi3+UeXEgvW6GOoEjgKjlTZBhnNYeoN4uzgZd/ mLN7gvVGioYdIjrOmrJei3lRhGXlGy8TGv8K4fT6CRK4HMIWL1OBx0F+k0zUhU9o RBuygNxIedi+SZ6Wrz25weJE0ZXGoEWVrUFNafNev39ehB+Bn+IQV036QcFZCul/ mw5/j7O3LWSG3dRWtm1NHHycsDOUW8XOszVl2q0aP6fGI+Zy2Mew0rxGLQqvF9v3 GhKXoizGj68YZSU3Icyb =IfQy -----END PGP SIGNATURE-----
--- End Message ---
-- debian-science-maintainers mailing list debian-science-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
