Antoine Beaupré pushed to branch master at Debian Security Tracker /
security-tracker
Commits:
5c97790c by Antoine Beaupré at 2018-11-22T16:52:53Z
inline explanation for why a package is unclaimed
A little more verbose explanation will help in diagnosing why a
specific package was unclaimed. It also shows the exact diff that was
used for comparison and the requested delay.
Requested-by: Holger Levsen <hol...@layer-acht.org>
- - - - -
d2d7dbf7 by Antoine Beaupré at 2018-11-22T16:52:53Z
clarify closing comment: we are editing the file
Previous wording seemed to indicate the user had to make a change by
hand, but the --unclaim paramater forcibly makes changes to the file
directly.
- - - - -
d353192c by Antoine Beaupré at 2018-11-22T16:52:54Z
look at the latest between update and claimed dates
Previous implementation wouldn't detect updates to the file and only
looked at the claimed dates. This was an oversight: the goal was to
take into account normal edits to the claimed block as well, so that
users can "ping" the claim to extend their claim.
- - - - -
1 changed file:
- bin/review-update-needed
Changes:
=====================================
bin/review-update-needed
=====================================
@@ -130,9 +130,13 @@ for entry in all_entries:
args.quiet or print("Claimed-Date:
{}".format(format_date(entry['claimed-date'])))
if args.unclaim:
- date_to_format = datetime.utcfromtimestamp(entry['claimed-date'])
+ if entry['last-update'] > entry['claimed-date']:
+ date_to_format =
datetime.utcfromtimestamp(entry['last-update'])
+ else:
+ date_to_format =
datetime.utcfromtimestamp(entry['claimed-date'])
if datetime.utcnow() - date_to_format > unclaim_delta:
unclaim_pkgs.append(entry['pkg'])
+ args.quiet or print("Unclaimed: idle for more than {}:
{}".format(unclaim_delta, datetime.utcnow() - date_to_format))
else:
args.quiet or print("Unclaimed-Since:
{}".format(format_date(entry['claimed-date'])))
if entry['last-update'] > entry['claimed-date']:
@@ -149,7 +153,7 @@ for entry in all_entries:
print("")
if args.unclaim:
- args.quiet or print("Packages to unclaim: {}".format(",
".join(unclaim_pkgs)))
+ args.quiet or print("Editing file to unclaim: {}".format(",
".join(unclaim_pkgs)))
in_preamble = True
with open(dsa_dla_needed) as orig, open(dsa_dla_needed + '.new', 'w') as
new:
for line in orig:
View it on GitLab:
https://salsa.debian.org/security-tracker-team/security-tracker/compare/2a165833d458c1c1ef949073ce050a9d7e51aaa1...d353192c6b6c50dfefae5b931a317b1975525565
--
View it on GitLab:
https://salsa.debian.org/security-tracker-team/security-tracker/compare/2a165833d458c1c1ef949073ce050a9d7e51aaa1...d353192c6b6c50dfefae5b931a317b1975525565
You're receiving this email because of your account on salsa.debian.org.
_______________________________________________
debian-security-tracker-commits mailing list
debian-security-tracker-commits@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-security-tracker-commits
