On Wed, 23 Jul 2003 07:40:33 +0100 Christoph Hellwig <[EMAIL PROTECTED]> wrote:
> On Tue, Jul 22, 2003 at 11:29:11PM -0700, David S. Miller wrote: > > And unlike this particular scsi layer usage, such drivers will be > > dependant upon things like CONFIG_PCI and thus won't get compiled > > in unless CONFIG_PCI has been enabled in the kernel configuration. > > Umm, no. The whole idea of the DMA mapping API is that it's independant > of the underlying bus. Think of usb or ieee1394 drivers doing direct DMA > independant of the bus the underlying host adapter uses. No USB or IEEE1394 on SBUS sparcs, so again no problem. My point still holds, please put this enumeration into a truly generic place that doesn't depend upon the actual implementation. linux/dma-dir.h or even linux/device.h seem the most logical place (we put the PCI ones in pci.h, and pci.h can be included cleanly even when CONFIG_PCI is disabled, consider that), then we make linux/dma-mapping.h and scsi/scsi_{cmnd,request}.h include this linux/{device,dma-dir}.h file. I don't see why this is a problem. Either do this, or fix asm-generic/dma-mapping.h which is not GENERIC because it depends upon something SPECIFIC, specifically PCI.