On 01/27/2010 12:35 PM, Ignace Mouzannar wrote:
On Wed, Jan 27, 2010 at 17:59, Michael B. Trausch<m...@trausch.us> wrote:
Hi Ignace,
Hello Mike,
Thank you for your prompt reaction!
I happened to be at the computer at the time. :-) Sorry that there was a
much larger delay in replying to this message.
You are working on adopting the AllTray package for Debian, am I
understanding that correctly? Do you know if Debian has distribution-local
patches? If so, I'd like to take them and move them upstream to the
old-maintenance branch on Launchpad. I'd be happy to help you with that.
You understood correctly, I intend to adopt AllTray. :)
There are no Debian specific patches; the two package versions
available in Debian (0.69-1 and 0.70-1) don't contain any patches.
The patches I intended to checkout/apply in the upcoming release are
the following:
- Bug#524683: Alltray trayicons use their own tooltip theme [1] [2]
- Bug#411459: Add multiple modifier support [3]
Do you want to apply these upstream?
The fix for Debian bug 524683 is already upstream. Note that the
lp:alltray/old-maintenance branch is the one that you'll be interested
in for looking at changes, since that is the one that is closest to
what's in Debian currently. It has other fixes as well, though I have
to go back and look to see precisely which ones there are.
The fix for bug 411459 I would be happy to have available in the
upstream source code. All fixes are welcome against the
lp:alltray/old-maintenance branch. If you have access to bzr, you are
also welcome to branch from there, merge in any changes (please, if
possible, arrange your commits so that it's one commit per bug fix, as
that would make it easier for me to review them before folding it into
the master maintenance branch). Otherwise, I'm also happy to take patch
files as long as they are based on the current mainline for that branch
and they apply cleanly (though, one patch for each bug, again, as that
makes it easier). If the patches are dependent on ordering, then please
make that known, too. It's quite likely an occurrence, given the source
code layout for it.
AllTray 0.70 is in "maintenance mode", that is, it is only open for
changes that fix bugs in its software. I tried to keep it as the basis
for AllTray's source code, but much of the code that is there is fragile
and rigid, and I could not do it without rewriting it. So, new AllTray
is in lp:alltray, and that is open for massive improvements, feature
requests, etc., while the old AllTray is just maintenance until I have a
new stable ready (at the point that I can release a new stable, which
will have the version number 0.8.0, old AllTray will cease to be in
maintenance and will become fully deprecated).
Also, there are many patches in the Ubuntu package, you may want to
take a look at these (I could send you these patches if you are
interested)?
Any patches that are in Ubuntu that for whatever reason have not yet
made it into the old-maintenance branch are welcome to be landed there
if they do not cause any new issues or break any of the existing code.
I can't spend a great deal of time on the old version (I'm currently
working on the new version, and stalled on that while I research some of
the painful lower-level details of X11 to finish it), but I will test
and merge all changes that correct defects in it.
Also, if there are bugs that are in Debian's bug tracker that are
problems with upstream old-maintenance AllTray, you're welcome to file
them with links to the Debian bug tracking system. Again, that's not to
say that they'll be priority for me fixing them, but since upstream
AllTray handles its bugs there, it would be a big help to just be able
to find the information all in one place.
Thanks a bunch!
Mike
--
Michael B. Trausch Blog: http://mike.trausch.us/blog/
Tel: (404) 592-5746 x1 Email: m...@trausch.us
--
To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
