On Tue, 18 May 2010 18:32:52 +0200, Nicolas Joseph wrote: > Hello,
Hello Nicolas, > I'm the author of this program. > > I am a Debian user and I have taken great care to create the package. If you're still interested, I'm available to review and sponsor it. > It's available on debian mentors: > http://mentors.debian.net/cgi-bin/sponsor-pkglist?action=details;package=valide > > Should you require any additional information, please do not hesitate to > contact me. Here are my comments on the packaging: - before seeing this bug, I downloaded the tarball from your website. Why is the one on the website 24M, and the one on mentors just 1.4M ? - debian/changelog: this package has never been released to Debian, so you should only have one stanza, with "Initial upload (Closes: #547665)" - debian/control: - Build-Depends: you're missing at least valac as dependency here. I haven't checked further. - Standards-Version: latest is 3.9.1, please update it - Vcs-* missing: if you're maintaining the debian/ directory under some VCS, please point to it using Vcs-Browser and Vcs-Svn (or Vcs-Git, Vcs-Bzr, [..]). - hardcoding runtime dependencies on shared libraries is bad. It doesn't let binNMUs. If ${shlibs:Depends} doesn't work, something's wrong, and should be fixed. - you're duplicating "Section: devel" in valide-common and valide-dev - long descriptions are a bit too "short" :) - valide-dev should depend on valide (= ${binary:Version}) - debian/copyright: you could choose to follow DEP-5, but that's entirely optional. - why do you have debian/patches/debian-changes-0.7.0-1? Please merge those changes upstream, and rebuild the package with a fixed orig.tar.gz - debian/valide*.install: you can just drop debian/tmp/ from there :) - debian/valide.lintian: should be named valide.lintian-overrides. After that, you can drop valide.dirs, and the hack in debian/rules to install this file. - debian/rules: why are you using that CMD=$(..) thing? You're using it only once, and I don't see any benefit in it :) Please let me know whether you still intend to maintain it, and eventually fix the above comments. Thank you, David -- . ''`. Debian developer | http://wiki.debian.org/DavidPaleino : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/ `. `'` GPG: 1392B174 ----|---- http://deb.li/dapal `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174
signature.asc
Description: PGP signature
