On 26/11/11 04:45, Paul Wise wrote: > On Sat, 2011-11-26 at 03:02 +0100, Carlos Alberto Lopez Perez wrote: > >> dget -x >> http://mentors.debian.net/debian/pool/main/a/aircrack-ng/aircrack-ng_1.1-2.dsc > > Blockers for the upload: > > The OpenSSL and GPL licenses are incompatible. A number of files do not > have the OpenSSL exception to the GPL. This means that we cannot > distribute any executables that link against OpenSSL and are also built > from those files. You will need to check which executables link against > OpenSSL, then check the license for all the associated source files > looking for ones licensed under the GPL without the exception. Once you > have done these checks, please document the results in debian/copyright. > If there are any binaries that have an issue, please delete those from > the package and ask upstream to fix the licenses. >
Thanks for notifying this (my fault for not checked it in advance). I have scanned all the source code and I found two files that are linking with OpenSSL and are GPL licensed without an exception to allow this. I have just reported it to upstream and also contacted Thomas. http://trac.aircrack-ng.org/ticket/953 > > Non-blockers that would be nice to have fixed: > > You might want to adopt the machine-readable format for debian/copyright > > http://dep.debian.net/deps/dep5/ > I will rewrite it with this format, thanks for the link ;) > Please remove me from Uploaders, I only plan to sponsor you, not > co-maintain the package. > Then.. who should put in Uploaders? me? nobody? > Please update to debhelper compat level 7 or higher. > > You may also want switch from a completely manual debian/rules to dh. > > debian/more-examples/README can be dropped from the source package since > that is covered by the upstream README. > > debian/README.source can be dropped since you are using dpkg-source v3. > > There are quite a few complaints from lintian (see bottom of the mail). > > Please add DEP-3 headers to all of the patches: > > http://dep.debian.net/deps/dep3/ > > I note that airdrop-ng and airgraph-ng are not installed in the package. > > Please forward the patches upstream that haven't been forwarded yet. > > There are lots of compiler warnings, please notify upstream about those. > > Please ask upstream what the status of the next release is. > > As a longer-term project, please consider figuring out which of the > injection patches are merged upstream, ask upstream to move those into > old/, drop those from the Debian package and talk to upstream about > merging the remainder into Linux mainline. > > lintian: > I: aircrack-ng source: quilt-patch-missing-description > 002-Fix_airodump-ng_manpage.diff > I: aircrack-ng source: quilt-patch-missing-description > 004-fix-license-sha1-sse2.diff > W: aircrack-ng source: debian-rules-missing-recommended-target build-arch > W: aircrack-ng source: debian-rules-missing-recommended-target build-indep > P: aircrack-ng: copyright-refers-to-symlink-license > usr/share/common-licenses/GPL > X: aircrack-ng: duplicate-files > usr/share/doc/aircrack-ng/injection-patches/ieee80211_inject.patch > usr/share/doc/aircrack-ng/injection-patches/old/ieee80211_inject.patch > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airbase-ng.1.gz:40 > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airbase-ng.1.gz:46 > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airbase-ng.1.gz:47 > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airbase-ng.1.gz:50 > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airbase-ng.1.gz:53 > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airbase-ng.1.gz:55 > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airbase-ng.1.gz:60 > I: aircrack-ng: spelling-error-in-manpage usr/share/man/man1/airbase-ng.1.gz > surpresses suppresses > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airbase-ng.1.gz:78 > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airbase-ng.1.gz:81 > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airbase-ng.1.gz:85 > I: aircrack-ng: spelling-error-in-manpage usr/share/man/man1/airbase-ng.1.gz > replys replies > I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/airbase-ng.1.gz > 7 more occurrences not shown > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/aircrack-ng.1.gz:116 > I: aircrack-ng: spelling-error-in-manpage usr/share/man/man1/aireplay-ng.1.gz > allows to allows one to > I: aircrack-ng: spelling-error-in-manpage usr/share/man/man1/airodump-ng.1.gz > Allows to Allows one to > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airodump-ng.1.gz:45 > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airodump-ng.1.gz:58 > I: aircrack-ng: hyphen-used-as-minus-sign > usr/share/man/man1/airodump-ng.1.gz:151 > I: aircrack-ng: spelling-error-in-manpage usr/share/man/man1/buddy-ng.1.gz > runned ran > I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/ivstools.1.gz:7 > I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/ivstools.1.gz:9 > I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/ivstools.1.gz:15 > I: aircrack-ng: hyphen-used-as-minus-sign usr/share/man/man1/ivstools.1.gz:17 > W: aircrack-ng: binary-without-manpage usr/sbin/airodump-ng-oui-update > Thanks for the tips. I will look at this after the blocking license issue is solved. Regards!
signature.asc
Description: OpenPGP digital signature
