I spend some time to analyze the diff between the 2 versions of gtkimageview, and, even after removing the renaming diff, the changes are not so trivial.
Considering that gtkimageview upstream was not modified since 1 year (viewnor's author could probably include the last fixes himself) , and that the version in viewnor is more than a copy/paste (patches, renaming, and only a part of gtkimageview is forked), I don't think it's so problematic to package it with the forked gtkimageview. Considering the time we have to maintain viewnor, packaging a modified version will probably end to an incomplete version, with some bugs we will not be able to fix. I'm not sure it's a good solution for Debian to add this type of application in the repositories. Regards, Julien Lavergne Le 11/27/2011 12:26 PM, Yao Wei a écrit : > > I forgot to mention that my modifications are in "gtkimageview" branch. > > https://github.com/medicalwei/Viewnior/tree/gtkimageview > > Sorry for your inconvenience. > ----- 原始郵件 ----- > > Hi, > > > > I can't see any modifications from the upstream trunk. Did you push the > > modifications to github ? > > > > Regards, > > Julien Lavergne > > > > Le 11/25/2011 05:41 AM, Yao Wei a écrit : > > > > > > Actually I did a runable diff in Github: (but some zooming and mouse > > > wheel won't work) > > > > > > http://github.com/medicalwei/viewnior > > > > > > ----- 原始郵件 ----- > > > > On 11/23/2011 07:02 AM, Julien Lavergne wrote: > > > > > > > > > Argh, bad news :( > > > > > > > > > > > > Yes, it turns this from a technical issue (package the app, and > make > > > > sure it meets packaging standards) into a much more difficult > "how to > > > > keep everyone happy" political issue! > > > > > > > > > Do we have an idea of the actual diff between the 2 versions ? > > > > > > > > > > > > I'll see if I can diff this over the coming weekend, unless someone > > > else > > > > does it first :) > > > > > > > > > Contacting gtkimageview upstream is a good idea, a backup plan > may > > > > > be to patch the package in Debian, but it's not a very nice > > > > > solution :( > > > > > > > > > > > > Another backup plan might be to create a "libviewnior" package with > > > > the modified library in it, and then a viewnior package that > depends > > > > on it and uses it instead of gtkimageview?? But I don't know if > > > > Debian would like/accept that as an approach. > > > > > > > > Jonathan > > > > > >
