Package: wnpp
Version: N/A; reported 2002-12-06
Followup-For: Bug #155879

Hi there,

I am willing to NMU the package libcarp-assert-perl as I need it to
get some other packages into Debian. I have downloaded the package
from your website and reviewed the packaging. It does currently need a
few changes, these are:

1) You should remove the debian/README.Debian as it does not contain
any useful information which is additional to what is already stated
elsewhere in your package.

2) You need to add the correct url for original download. It is
actually something like:
http://search.cpan.org/CPAN/authors/id/M/MS/MSCHWERN/.

3) You need to put a note as to location of the Perl license into
debian/copyright (/usr/share/doc/perl/copyright).

4) debian/rules should be corrected so the build is done in
binary-indep not binary-arch, (basically just swap the binary-indep
and binary-arch targets around).

5) debian/rules needs to be fixed so it creates *.3perl man pages not
*.3pm, this is done by using the MAN3EXT=3perl option when doing the
make and make install phases. e.g.:

   $(MAKE) OPTIMIZE="-O2 -g -Wall" MAN3EXT=3perl

   $(MAKE) install PREFIX=$(CURDIR)/debian/libcarp-assert-perl/usr MAN3EXT=3perl

6) You should be aware that although removing all empty directories is
a good idea there is a subtle bug in your find command in that xargs
splits on white space so a directory path containing whitespace (which
could happen with Linux) will be broken up into two incorrect
pieces. You should look at using the -0 (--null) option with xargs to
make it safer.

7) You are including Makefile.old in your package which accounts for a
huge portion of the created diff (806 lines out of a 956-line diff). I
think you need to do a 'make distclean' in your clean target in
debian/rules rather than just 'make clean'. And then possibly do a
'debuild clean' before you next build the package. The diffstat
package is a great tool for examining the diff output of debuild.

Basically most of these points (2,3,4 & 5) are necessary to make the
package comply with debian policy. You should read through the
perl-policy document

http://www.debian.org/doc/packaging-manuals/perl-policy/

If you fix all these issues, let me know and I will happily upload the
fixed package. I am looking to get my own packages in fairly soon so I
will go ahead and fix the bugs and upload if I don't hear anything
from you in the next couple of weeks.

Thanks,
        Stephen Quinney

-- System Information
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux mizar 2.4.20 #1 Fri Nov 29 09:22:48 GMT 2002 i686
Locale: LANG=C, LC_CTYPE=


Reply via email to