Hi Sebastian! Thank you very much for your review. Those were really some major flaws.
On 01/19/2016 12:54 PM, Sebastian Ramacher wrote: > A new upstream version is available. I managed to get most of this fixed upstream. I am just waiting for another release, so that we don't need to have unnecessary patches. > Why is linbpng-dev in Build-Depends? It doesn't seem to be used. Removed it. Its not required you are right. > Is there a reason libnordlicht0 and libnordlicht-dev are not > multi-archified? I provided some patches to upstream and will multi-archify the package as soon as the new release is out. https://github.com/cinemast/nordlicht/commit/4440b64eff581da855140867f6e9a8b0a599eaf0 > The library exports plenty of symbols that are not listed in > nordlicht.h. Please hide those symbols (for example using > __attribute__(visibility("hidden"))) and ideally get this fixed > upstream. > Fixed upstream: https://github.com/nordlicht/nordlicht/commit/cc86cd362844700fced80ebcf443bb8f8a82c961 > nordlicht is overlinked: > > dpkg-shlibdeps: warning: package could avoid a useless dependency > if debian/nordlicht/usr/bin/nordlicht was not linked against > libavcodec-ffmpeg.so.56 (it uses none of the library's symbols) > dpkg-shlibdeps: warning: package could avoid a useless dependency > if debian/nordlicht/usr/bin/nordlicht was not linked against > libavformat-ffmpeg.so.56 (it use s none of the library's symbols) > dpkg-shlibdeps: warning: package could avoid a useless dependency > if debian/nordlicht/usr/bin/nordlicht was not linked against > libavutil-ffmpeg.so.54 (it uses none of the library's symbols) > dpkg-shlibdeps: warning: package could avoid a useless dependency > if debian/nordlicht/usr/bin/nordlicht was not linked against > libswscale-ffmpeg.so.3 (it uses none of the library's symbols) > > libnordlicht.so.0 is underlinked. Please link it against libm: > > dpkg-shlibdeps: warning: symbol log10 used by > debian/libnordlicht0/usr/lib/libnordlicht.so.0 found in none of the > libraries Fixed upstream: https://github.com/nordlicht/nordlicht/commit/f69acc20599b8bf3edb8dd2986c1026b27af28a9 I will commit the missing changes about multi-arch support and a new symbols file as soon as the new release is out. Could you please than give it another chance? Thank you and Greetings Peter
