On Tue, Jul 05, 2016 at 11:37:07PM +0100, Alessandro Ghedini wrote: > TBH I don't really care about the other packages and I don't have enough time > to review something I don't care about, sorry :/ fair enough
> > As for golang-github-docopt-docopt-go, I looked at your repo and it looks good > except for a few small nits: > > * You remove bith binaries and examples from the target directory, but it > seems you missed a couple of files that should also be removed: > > -rw-r--r-- root/root 42954 2016-07-03 05:04 > ./usr/share/gocode/src/github.com/docopt/docopt-go/docopt_test.go > -rw-r--r-- root/root 891 2016-07-03 05:04 > ./usr/share/gocode/src/github.com/docopt/docopt-go/example_test.go I thought they may be useful if you were to link against docopt-go, but they really aren't. deleting them > > * I think the examples/ directory should be included in the package but > installed as examples files. See dh_installexamples(1) for more > information, > but basically you'd need to create an *.examples file under debian/ listing > which file / directory to install as example. I don't agree, I think most people will use upstream Golang to develop Go apps so they will use go get. However, I you develop Go apps and you think is usefull to have examples on the Debian packages I can put them back. I lack of experience on the matter as I don't develop Go applications. > > * The git repo doesn't have an upstream/ tag. You also probably want to wait > to create the debian/ one until after the package is uploaded. Otherwise > you'll need to delete it and recreate it if you need to do some changes. > In general when sponsoring a package, I prefer to create the tag myself > just before uploading (so you don't need to generate it yourself). upstream tags are not prefixed, they are 0.6.1, 0.6.2, etc. I've deleted the Debian tag I've pushed to alioth, take a look to it thanks > > Thanks for your work :) > > Cheers -- 1AE0 322E B8F7 4717 BDEA BF1D 44BB 1BA7 9F6C 6333 keybase: http://keybase.io/gfa
