Hi, So sorry for this time to answer.
El 26/07/16 a las 14:56, Luca Boccassi escribió: > On Tue, 2016-07-19 at 17:08 +0200, santiag...@riseup.net wrote: > > Hi, > > > > El 06/07/16 a las 10:27, Luca Boccassi escribió: > > > On Mon, 4 Jul 2016 13:57:33 +0200 Christian Ehrhardt > > > <christian.ehrha...@canonical.com> wrote: > > > > On Sun, Jul 3, 2016 at 8:52 PM, Santiago Ruano Rincón > > > > <santiag...@riseup.net > > > > > wrote: > > > > > > > > > Hi all, > > > > > > > > > > On Thu, 14 Apr 2016 21:34:11 +0100 Luca Boccassi > > > > > <luca.bocca...@gmail.com> wrote: > > > > > > On Wed, 30 Mar 2016 08:38:58 +0200 Christian Ehrhardt > > > > > > <christian.ehrha...@canonical.com> wrote: > > > > > > > On Wed, Mar 30, 2016 at 7:41 AM, C.J. Collier > > > > > > > <cjcoll...@linuxfoundation.org > > > > > > > > wrote: > > > > > > > > > > > > > > > On Wed, 24 Feb 2016 11:51:20 +0100 Christian Ehrhardt > > > > > > > > <pael...@gmail.com> > > > > > > > > wrote: […] > > However, lintian is not happy, as you can see in the attached report. > > Some of the points to highlight from it that, IMHO could block uploading > > are: > > > > 1. W: libdpdk-librte-pmd-xenvirt1: package-name-doesnt-match-sonames > > librte-pmd-xenvirt1 and related: > > Any reason to add the libdpdk- name prefix to the librte-* libraries? > > Usually, the name of a binary library package follows its SONAME, and > > thus just librte-* would be more accurate. > > Some time ago the libraries were renamed and no longer have the libdpdk- > prefix: > > https://gerrit.fd.io/r/gitweb?p=deb_dpdk.git;a=blob;f=debian/control;h=37a64437bf1d566082477923d91618c1b9016725;hb=refs/heads/deb_dpdk_16.07 Humm, I was following the master branch instead. Any reason to don't merge this deb_dpdk_16.07 into master? I am starting to work over this branch now, so I will have to do part of the job again. For the moment, the rest of the mail is a quick answer. > > 2. Hardening: it seems that build flags need to be fixed. E.g: > > W: libdpdk-librte-eal2: hardening-no-relro > > usr/lib/x86_64-linux-gnu/librte_eal.so.2 > > Some were fixed, but yes indeed there's a few more to deal with, will do as > soon as I have time. But given the possible performance implications it might > be good to consult with upstream. Indeed, seems to be fixed. Thanks! > > > 3. I am not sure the licensing (and then debian/copyright) is not as > > simple as a dual GPL-2/BSD for core stuff and GPL for kernel components, > > as README states. I will check carefully this, since no accurate > > debian/copyright, no upload possible. > > I'm pretty sure that's what upstream advertises and a quick run of > licensecheck seems to confirm that, but if you find otherwise please do flag > that both with us and upstream Actually, my wording was not accurate either, since README doesn't claim *dual* licensing but different licenses for different components. BSD (3-clause) for the core and GPLv2 for kernel-related. Anyway, licensecheck outputs files under other licenses. E.g.: […] ./drivers/crypto/qat/qat_adf/icp_qat_fw.h: BSD (3 clause) GPL (v2) ./drivers/crypto/qat/qat_adf/icp_qat_fw_la.h: BSD (3 clause) GPL (v2) ./drivers/crypto/qat/qat_adf/adf_transport_access_macros.h: BSD (3 clause) GPL (v2) ./drivers/crypto/qat/qat_adf/qat_algs_build_desc.c: BSD (3 clause) GPL (v2) […] ./lib/librte_compat/rte_compat.h: BSD (2 clause) […] Attached you can find a patch for debian/copyright, that I think it's accurate with the current source. FTR, it is based on (and thanks to): licensecheck --copyright -r `find * -type f` | \ /usr/lib/cdbs/licensecheck2dep5 > debian/copyright.auto Also, AFAICS there are a couple of files in lib/librte_net/ that need some cleaning by upstream. > > > 4. It would be great to have manpages for these binaries: > > > > W: dpdk: binary-without-manpage sbin/dpdk_nic_bind > > W: dpdk: binary-without-manpage usr/bin/dpdk_proc_info > > W: dpdk: binary-without-manpage usr/bin/testpmd > > Yes absolutely, patches are welcome :-) Unless somebody else beats me, I will try do them at some point. Cheers, Santiago
>From 75565d2710fa5ea75595c2458eb3d6ea35a3866d Mon Sep 17 00:00:00 2001 From: Santiago <santiag...@riseup.net> Date: Wed, 14 Sep 2016 17:42:54 +0200 Subject: [PATCH] Review debian/changelog --- debian/copyright | 167 ++++++++++++++++++++++++++++++++++++------------------- 1 file changed, 110 insertions(+), 57 deletions(-) diff --git a/debian/copyright b/debian/copyright index 48ca4f8..1897203 100644 --- a/debian/copyright +++ b/debian/copyright @@ -5,17 +5,110 @@ Source: http://dpdk.org Files: * Copyright: 2008-2014 Cisco Systems, Inc. 2012-2014 6WIND S.A. - 1999-2015 Intel Corporation. + 1999-2016 Intel Corporation. 2010-2013 Tilera Corporation. - 2012 Mellanox. + 2012-2016 Mellanox. 2007 VMware, Inc. 2007 Nuova Systems, Inc. 2014 IBM Corporation. -License: BSD+GPLv2+LGPLv2 - BSD: - Copyright (c) The Regents of the University of California. - All rights reserved. + and many other contributors. +License: BSD-3-clause + +Files: lib/librte_eal/linuxapp/* +Copyright: 2007-2016, Intel Corporation + 2006-2007 Myricom, Inc. for some LRO specific code +License: GPL-2 + +Files: drivers/net/enic/* +Copyright: 2007, Nuova Systems, Inc. + 2008-2016, Cisco Systems, Inc. +License: BSD-2-clause + +Files: + lib/librte_eal/common/include/rte_pci_dev_*.h + lib/librte_eal/linuxapp/xen_dom0/* + lib/librte_vhost/eventfd_link/eventfd_link.h + drivers/crypto/qat/qat_adf/* +Copyright: 2010-2016, Intel Corporation. +License: BSD-3-clause or GPL-2 + +Files: + lib/librte_eal/bsdapp/eal/include/exec-env/rte_dom0_common.h + lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h + lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h +Copyright: 2007-2014, Intel Corporation. +License: BSD-3-clause or LGPL-2.1 + +Files: lib/librte_compat/rte_compat.h + script + drivers/net/vmxnet3/base/upt1_defs.h + drivers/net/vmxnet3/base/vmxnet3_defs.hs/validate-abi.sh +Copyright: 2015, Neil Horman <nhor...@tuxdriver.com> + 2007, VMware, Inc. +License: BSD-2-clause + +Files: buildtools/pmdinfogen/* +Copyright: 2016, Neil Horman <nhor...@tuxdriver.com> +License: GPL-2 + +Files: debian/* +Copyright: 2015, 2016 Canonical Ltd. +License: GPL-3 + +License: BSD-2-clause + Redistribution and use in source and binary forms, with or without + modification, are permitted provided that the following conditions + are met: + . + 1. Redistributions of source code must retain the above copyright + notice, this list of conditions and the following disclaimer. + . + 2. Redistributions in binary form must reproduce the above copyright + notice, this list of conditions and the following disclaimer in + the documentation and/or other materials provided with the + distribution. + . + THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; + LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER + CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + POSSIBILITY OF SUCH DAMAGE. + +License: BSD-3-clause + Redistribution and use in source and binary forms, with or without + modification, are permitted provided that the following conditions + are met: . + * Redistributions of source code must retain the above copyright + notice, this list of conditions and the following disclaimer. + * Redistributions in binary form must reproduce the above copyright + notice, this list of conditions and the following disclaimer in + the documentation and/or other materials provided with the + distribution. + * Neither the name of Intel Corporation nor the names of its + contributors may be used to endorse or promote products derived + from this software without specific prior written permission. + . + THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR + A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT + OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, + SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT + LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, + DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY + THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +License: BSD-4-clause Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: @@ -24,7 +117,11 @@ License: BSD+GPLv2+LGPLv2 2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. - 3. Neither the name of the University nor the names of its contributors + 3. All advertising materials mentioning features or use of this software + must display the following acknowledgement: + This product includes software developed by the University of + California, Berkeley and its contributors. + 4. Neither the name of the University nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission. . @@ -39,59 +136,15 @@ License: BSD+GPLv2+LGPLv2 LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - . - GPL: - This package is free software; you can redistribute it and/or modify - it under the terms of the GNU General Public License as published by - the Free Software Foundation; either version 2 of the License, or - (at your option) any later version. - . - This package is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU General Public License for more details. - . - You should have received a copy of the GNU General Public License - along with this program. If not, see <http://www.gnu.org/licenses/> - . + +License: GPL-2 On Debian systems, the complete text of the GNU General Public License version 2 can be found in "/usr/share/common-licenses/GPL-2". -Files: debian/kernel-version - debian/prepare-modules -Copyright: 2009-2016 Andreas Beckmann <a...@debian.org> - 2010-2016 Russ Allbery <r...@debian.org> -License: GPL-2.0+ - This package is free software; you can redistribute it and/or modify - it under the terms of the GNU General Public License as published by - the Free Software Foundation; either version 2 of the License, or - (at your option) any later version. - . - This package is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU General Public License for more details. - . - You should have received a copy of the GNU General Public License - along with this program. If not, see <http://www.gnu.org/licenses/> - . - On Debian systems, the complete text of the GNU General Public - License version 2 can be found in "/usr/share/common-licenses/GPL-2". - -Files: debian/* -Copyright: 2015, 2016 Canonical Ltd. License: GPL-3 - This program is free software: you can redistribute it and/or modify it - under the terms of the GNU General Public License version 3, as published - by the Free Software Foundation. - . - This program is distributed in the hope that it will be useful, but - WITHOUT ANY WARRANTY; without even the implied warranties of - MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR - PURPOSE. See the GNU General Public License for more details. - . - You should have received a copy of the GNU General Public License along - with this program. If not, see <http://www.gnu.org/licenses/>. - . On Debian systems, the complete text of the GNU General Public License version 3 can be found in "/usr/share/common-licenses/GPL-3". + +License: LGPL-2.1 + On Debian systems the full text of the GNU LGPL v2.1 can be found + in the `/usr/share/common-licenses/LGPL-2.1' file -- 2.1.4
