On 2017-01-09 14:25:50, Ana C. Custura wrote: > Hi, > > I was wondering if you're still interested in sponsoring this, it's > still on mentors if you happen to have time to look at it. If not, > that's ok as there's someone else I can potentially ask. > > Let me know and thanks again!
Hi, Sorry for the delay, here's a quick review. (1) The package description could be improved... Use more spaces between paragraphs. In control files, paragraphs are marked like this: """ Here is a set of tools to perform basic audits on your DNS requests and responses to make sure your DNS is working as you expect. You can measure the response time of any given DNS server for arbitrary requests using dnsping. Just like traditional ping utility, it gives you similar functionality for DNS requests. . You can also trace the path your DNS request takes to destination to make sure it is not being redirected or hijacked. """ Notice the line with a simple dot on it? (2) Also, I would remove the series of questions on the first lines of the description. We are aiming at more neutral description of what the package does, not an advertisement. :) (3) The Vcs-Git line is incorrect - it needs to be a proper git URL: $ git clone https://anonscm.debian.org/git/pkg-netmeasure/dnsdiag.git Clonage dans 'dnsdiag'... fatal: repository 'https://anonscm.debian.org/git/pkg-netmeasure/dnsdiag.git/' not found I suggest you use collab-maint as it is easy to get access to it. If you already have access to the pkg-netmeasure group, that's fine too, but be sure to push your changes there. See this page for collab-maint: https://wiki.debian.org/CollaborativeMaintenance (4) Why do you use a `.install` file instead of letting the regular setup.py install targets do their thing? (5) in the patches, I recommend you follow the patch tagging guidelines documented here: http://dep.debian.net/deps/dep3/ for example, i'd be curious to hear why the cmrywhois patch is required or what the "test.diff" patch actually does (or why it's called "test"!)... (6) the watch file is a bit odd - there's a commented out line, but then it still kind of works because the next line kicks in... it confuses the mentors site as well, so you probably want to clean that up. Otherwise I tested the package and it looks sound - the above is mostly small details and changes, but those will sure be a problem when we do the first upload, so make sure to followup on those. :) Thanks for packaging dnsdiag! Unfortunately, it is too late to make it into stretch, and that's my fault, but we will be able to backport this fairly easily I believe... Cheers, A. -- Je viens d'un pays où engagé veut dire que tu t'es trouvé une job. - Patrice Desbiens
