Hi,

On Sat, Jan 28, 2017 at 10:11:53AM +0100, dada wrote:
> 
> Le 2017-01-27 09:28, Andreas Tille a écrit :
> >thanks for preparing openmeca.  Here are some remarks:
> >  d/changelog:
> >   - you created several sections all featuring your name
> >     that's not sensible in general
> >   - a changelog for the first upload should not contain more
> >     than "Initial release. (Closes: #850590)"
> that's done

OK, I've removed the last remaining redundant instance.

I also reverted the commit that was injecting a patched version.
Please make sure you do

    quilt pop -a

before commiting.
 
> >  d/control:
> >   - per policy you should use "Priority: optional"
> >   - please normalise via
> >       cme fix dpkg-control
> that's done

Fine.
 
> >   - do you have good reasons to specify lib* instead of just
> >     trusting ${shlibs:Depends} ?
> You right, these libs were removed rom dependencies

OK.

> >BTW, you can use debhelper compat level 10 (d/compat) and
> >Build-Depend debhelper (>= 10).
> that's done, (I was confusing between debian stable and debian testing
> realease)

There might be good reasons for sticking to debhelper 9 but a backport
to stable would not be such good reason since debhelper 10 is backported
as well.

> >Please fix these issues and I'll try a build (if nobody will
> >beat me with sponsering which is always welcome ;-)).
> 
> Thank you very much for your reviewing and your help,

You are welcome.  Please also add pristine-tar branch to the repository.
Policy recommends to do

   gbp import-orig --pristine-tar YOUR_TARBALL

which keeps metadata about the tarball in a pristine-tar branch.

Kind regards

        Andreas. 

-- 
http://fam-tille.de

Reply via email to