Hello Birger, On Wed 06 Feb 2019 at 07:54AM +01, Birger Schacht wrote:
> * Package name : swaylock > Version : 1.3 > Upstream Author : Drew DeVault <s...@cmpwn.com> > * URL : https://github.com/swaywm/swaylock > * License : MIT > Programming Lang: C > Description : Screen locker for Wayland > > swaylock is a screen locking utility for Wayland compositors. It is > compatible with any Wayland compositor which implements the following > Wayland protocols: > * wlr-layer-shell > * wlr-input-inhibitor > * xdg-output > * xdg-shell Here is a review of 566c844e8e78c5eff3c5c638e8877efad16f99b0 in your repo on salsa. - The copyright years for upstream need to be 2016-2019, not 2016-2018. - Are you sure that Nicolas doesn't share copyright of debian/? Did you make debian/ from scratch, or copy parts of it from the old sway source package? - There is this Lintian warning; since we are uploading to unstable, ideally you'd add a patch to fix it, and forward that upstream: W: swaylock: manpage-has-errors-from-man usr/share/man/man1/swaylock.1.gz 70: warning: macro ':'' not defined - Be sure to `dch -r` when you've fixed these. Otherwise, we should be good to go. -- Sean Whitton
signature.asc
Description: PGP signature
