Hello Birger, On Sat 09 Feb 2019 at 01:42PM +01, Birger Schacht wrote:
> i've updated the package to 1.0-rc1 and pushed to the git repo. Thank you for working on this! For my own reference: this e-mail reviews edcdf846db12a6dc7495caea02bad2faa30586fb. > Changes since beta2: > * New upstream release > * Remove swaylock and swayidle: they are now separate packages > * Clean up d/sway.install "Cleaning up" suggests only deleting lines, but you also added some wildcards, so "tidied up" would be better. This is an extremely minor point :) > * Specify versioned build-dependencies and add libelogind > and libsystemd build-dep > * Remove references to swaygrab You need to mention the new wayland-protocols build-dep, too. Normally you would also specify /why/ the build-deps now need to be versioned (someone should not need to guess why the scdoc build-dep needs to be 1.8.1, for example). Since this is a NEW package, it doesn't matter, so I'm telling you about this for the future. It would also be worth mentioning why swaygrab is no longer referenced. Again, though, it doesn't matter because this package is NEW. > * Update Recommends and Suggests Similarly, more detail would be useful, though it doesn't matter much since the package is NEW. > * Make versioned run dependency on libwlroots0 explicit Please explain (either in the changelog or with a comment in d/control) why this is needed -- it's unusual not to be able to rely on dpkg-shlibdeps doing this for you. This does matter, even if the package is NEW. > There are new lintian warnings: > > I: sway: file-references-package-build-path usr/bin/sway > [...] > I think this refers to the occurrence of strings like: > ../sway/commands/exec.c > in the binaries. This is a relative path and the lintian warning is > about reproducability, so i think this is a false negative? This doesn't need to block an upload to experimental, so I'll leave it to your judgement. Thanks for investigating. I haven't tried installing and running the package yet, btw, but I guess that you have done this. I'll give it a try before the upload. After you've responded to the above, please remember to `dch -r`! -- Sean Whitton
signature.asc
Description: PGP signature
