On Wed, Nov 08, 2023 at 05:52:05PM +0800, Maytham Alsudany wrote: > On the contrary, avoiding the use of dh-golang as done in this repo[3] causes > all the tests to pass without problem, and I'm unsure to why that is.
This was due to some caveats with the build system and also how
dh_golang works. We added in a patch that'd skip running gen-go-code.py
and this was being used at more than one place.
I've fixed up the build and the tests and the package seems to
build/work. I suppose we should be pushing it to debian experimental for
now since this introduces some completely new things. Let me know if you
disagree.
I've pushed all my changes to the debian/experimental branch on the
existing salsa repo[5] and also added your access to it so you could
push directly.
> We may have to take the approach Fedora has taken, where they've skipped any
> continuously failing tests[4].
For now I disabled two tests in the go code that tries to fiddle with
proc/devfs and can potentially fail in a chroot. Python tests probably
also try to do some non-standard stuff and we could disable it later if
it goes flaky on the buildd machines.
That said, I want to discuss/ask a few things:
* Can you take a look at my commits and let me know if you have any
comments?
* Can you please clean up some of the lintian stuff? And then we could
upload the new release.
* Since we both are interested in kitty's packaging, I think we have two
options:
- Either you or me would be in the "Maintainer" field and the other one would
be in "Uploader" field.
- Add ki...@packages.debian.org as the maintainer and add both of us
as uploaders (that means we subscribe to the package email
ofcourse).
Which one do you think we should do?
* I suppose the maintenance of this package will keep getting messy due
to upstream mixing up two language build systems in a fairly non-standard way.
I suppose it makes sense to ask upstream if they'd consider to switch
to something that eases maintenance burden on us (Debian). WDYT?
> [1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1037440#37
> [2]: https://salsa.debian.org/Maytha8/kitty-dh-golang
> [3]: https://salsa.debian.org/Maytha8/kitty
> [4]: https://src.fedoraproject.org/rpms/kitty/blob/rawhide/f/kitty.spec#_268
[5]:
https://salsa.debian.org/debian/kitty/-/tree/debian/experimental?ref_type=heads
Best,
Nilesh
signature.asc
Description: PGP signature
