Hello Daniel, thanks for your comments! * Daniel Baumann <[EMAIL PROTECTED]> wrote: > * tipp: debhelper (>> 4.0.0) is over-precise, > debhelper (>= 4) is just enough.
Changed. (Out of curiosity, does it make a difference?) > * should: since you wrote ocamlwc.1 yourself, > you should structure it like the more common > examples, incl. adding a AUTHOR section. > look at gproftpd for a sane example. I think the manpage is quite standard (in particular, it doesn't invent any section names). If I'm going to add an AUTHOR section, then I would prefer to only mention the author of the software itself: Nobody cares about who wrote the manpage. Besides, I don't want to claim that I *wrote* it, since I just took the program's usage message together with some roff macros and added two lines. What do you think? > * must: instead of patch, you should use patch-stamp in rules. Why? dpatch.make(7) says: Using dpatch.make is rather straightforward: one has to include the file in debian/rules, change the appropriate targets to depend on patch and unpatch, and that is all it takes. In fact, in /usr/share/dpatch/dpatch.make, the patch target depends on patch-stamp. > * should: remove the > ## All lines beginning with `## DP:' are a description of the patch. > line from the dpatch header. Done. > * should: you do not ship a shared library, hence remove the > useless dh_makeshlibs from your rules. Oh yes, fixed. > * should: you do not have a shlibs:Depends in control, > hence remove the useless dh_shlibdeps from your rules. Dito. Another question. The Debian OCaml Policy (section 2.2) says: A bytecode package must build-depend-indep on ocaml-nox-3.09.2 (or ocaml-3.09.2 if the program either uses the Graphics or the LablTk module). The current version number of OCaml should not be hardcoded into the build-dependency (this is a deviation from a practice which used be recommended but is depreciated now). Of course, if it is necessary to ensure that the version of OCaml has a certain value then version constraints can be used. However, this should be justified by the requirements of the compilation of the program. This is not clear to me. It says I should build-depend-indep on ocaml-nox-3.09.2. However, wouldn't this mean "hardcoding the current version number of OCaml into the build-dependency"? Currently, I just have "Build-Depends-Indep: ocaml-nox". > if you fix above things, i'll sponsor this package. Thank you! Happy new year, Georg -- Who says nothing is impossible? I've been doing nothing for years. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]