Hi Reinhard, Am Montag, den 25.08.2008, 09:07 +0200 schrieb Reinhard Tartler: > here some notes I made while reviewing the loggerhead package: > > - it installs a conffile /etc/loggerhead.conf. After having a short > look at it, it seems to me that for almost every usecase, the user is > expected to edit this file. This means that on every upgrade where we > edit the default config, a conffile change will happen. I don't think > this is really what we want. > > How about shipping the default config in > /usr/share/doc/loggerhead/example.conf and guide the user in a > README.Debian file to copy it manually to /etc/loggerhead.conf? He > needs to adapt the file anyways. This way we can also get rid of that > /etc/default/loggerhead file. The initscript could then just check > for the presence of /etc/loggerhead.conf and be done with it. I've never done it that way, but it seems sensible. Wouldn't that mean that purging loggerhead keeps loggerhead.conf around thought?
> - init script. The dependencies in loggerhead currently state this: > > # Required-Start: $remote_fs $syslog > # Required-Stop: $remote_fs $syslog > > I'm not sure if this is right. The source does not reference syslog > anywhere, moreover, AFAIUI loggerhead requires the network to be > up. Therefore I suggest "$local_fs $remote_fs $network" instead > (inspired by the apache2 init script) I forgot to modify these when I copy-n-pasted from another page. Should be fixed now. > - any particular reason to upload to experimental? I propose uploading > to unstable instead. Sure, it won't make it for the lenny release, > but unless it is in an highly experimental state that we don't want > 'regular' users to use and test it, I see no reason to 'hide' it in > experimental. More habit really - I upload new stuff to experimental usually to keep unstable free for uploads that have to go into lenny, but that doesn't make sense here so I've changed the distro back to unstable. > Please comment on the 3 points above and indicate if you agree or > disagree. I'll go on with uploading when we sort these changes out. These all three sound sensible - I've uploaded a new package with these changes to mentors.debian.net and pushed to bzr.debian.org. Cheers, Jelmer -- Jelmer Vernooij <[EMAIL PROTECTED]> - http://samba.org/~jelmer/ Jabber: [EMAIL PROTECTED]
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil