FYI, I have prepared another package (available at http://mentors.debian.net/debian/pool/main/l/libcas-php/libcas-php_1.0.1-2.dsc)
In order to address the following issues : On Tue, Nov 18, 2008 at 09:42:29AM +0100, Olivier Berger wrote: > > Le lundi 17 novembre 2008 à 15:20 -0600, Raphael Geissert a écrit : > > Olivier Berger wrote: > > [...] > > > > > > debian/rules: > > What about cleaning it up? > > > Sure. > done > > debian/copyright: > > > Upstream Author: > > > > > > Pascal Aubry > > > > What about also displaying his email address? > Sure. done > > > > > > License: (stated at : http://www.ja-sig.org/wiki/display/CASC/phpCAS) > > what about docs/README? > > > Sure... and it appears to be missing from the package, btw :( Fixing > that. > done > > debian/dirs: > > empty? delete it > Yup. somehow fixed, as it has reappeared (see bellow) > > > > > debian/docs: > > ditto > No longer, added upstream README. done > > > > > debian/README.Debian: > > > This packaging needs testing as I'm not fully sure there ain't > > > regressions introduced by this upgrade of the DOM parsing library. > > > > Have you at lest tested the basic functionality of the library with the > > newer > > version of domxml-php4-php5.php or are you blindly packaging stuff? > > No I have tested it, but you never exactly know for corner cases like > error messages hard to test. > > Btw, my main motivation for packaging it is to use it on a production > server, so I'd better have it tested of course. > > In any case I preferred some explicit mention that it's not exactly > upstream's version, to let people know who's to blame in case of > problem. > > Will rephrase as : > > Differences from upstream version : > ----------------------------------- > > This package includes a Debian specific patch, to replace > domxml-php4-php5.php version 1.5.5 (shipped with version 1.0.1 > of > phpCAS) by version 1.20a of domxml-php4-to-php5.php, which is > now > under LGPL, making it DFSG-free. > > Best care was taken by the Debian packager to make sure there > ain't > regressions introduced by this upgrade of the DOM parsing > library. Please report to the Debian BTS if you experience > problems > related to that change. done > > > > > CAS.php: > > > define("CAS_PGT_STORAGE_FILE_DEFAULT_PATH",'/tmp'); > > .. > > > define("CAS_PGT_STORAGE_FILE_FORMAT_PLAIN",'plain'); > > > > Doesn't look good at all. > > Hmmm... I guess that needs to be fixed indeed. Thanks for spotting that. I have applied a patch in order to use /var/lib/libcas-php/pgtstorage/ and not /tmp for storage. Hope I did it in a safe way. In addition, I have tested more the proxy mode and fixed a nasty crash that occurred in validatePGT with the new domxml-php4-to-php5. Changes to the previous package are : libcas-php (1.0.1-2) unstable; urgency=low * Cleanup debian/rules. * Add missing updtream README in docs/. * Move PGT storage dir to /var/lib/libcas-php/pgtstorage/ for safety reasons. * fix crash of validatePGT() when using new domxml-php4-to-php5.php (upstream bug PHPCAS-35) -- Olivier Berger <[EMAIL PROTECTED]> Tue, 18 Nov 2008 16:35:12 +0100 Any comments welcome Best regards, -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]