Bug#469397: xbmc package test

[Sebastian Reichel]

Hi,

I'm not a DD, so I can't sponsor your package, but I wanted to try
xbmc, so I tested the package. When building the package I noticed
the following:

* It only works with libmpcdec-dev from unstable, not with the
  version from experimental. you may add (<< 2:0.1~r444-1)
  to Build Dependencies.

I tried xbmc-live and this package is not working like it should be:

* the init.d script uses kernel parameters for configuration. e.g.
  'splash' is needed as kernel parameter to start xbmc. IMHO this
  should be moved to /etc/default/xbmc in connection with debconf.
* the init script starts xbmc via /usr/bin/runXBMC, which is broken
  by default (it does not export xbmc home before starting xbmc).
  This can be fixed by modification of /usr/bin/xbmc, so that it
  exits with the exit code of xbmc and another modification of
  runXBMC to use xbmc wrapper script instead of doing the same
  as the wrapper script ;)

These are my updated files:

elektra...@sun ~ % cat /usr/bin/xbmc
#!/bin/sh

# Set XBMC_HOME if xbmc.bin is a symlink
if [ -L /usr/share/xbmc/xbmc.bin ]; then
  export XBMC_HOME="/usr/share/xbmc"
fi

python /usr/share/xbmc/FEH.py "$@"
if [ $? -ne 0 ]; then
  exit
fi
/usr/share/xbmc/xbmc.bin "$@"
CODE=$?
while [ $CODE -eq 65 ]
do
  /usr/share/xbmc/xbmc.bin "$@"
done

exit $CODE
elektra...@sun ~ % cat /usr/bin/runXBMC 
#!/bin/bash

if [ "$(pidof X)" ] ; then
    /usr/share/xbmc/xbmc.bin  --standalone
    exit
fi

while true
do
    echo "#!/bin/bash" >  /home/xbmc/.xsession
    echo "xbmc --standalone" >>  /home/xbmc/.xsession

    echo "case \"\$?\" in" >>  /home/xbmc/.xsession
    echo "    0 ) # Quit" >>  /home/xbmc/.xsession
    echo "        touch /tmp/noRestartXBMC" >> /home/xbmc/.xsession
    echo "        break ;;"  >>  /home/xbmc/.xsession
    echo "    64 ) # Shutdown System"  >>  /home/xbmc/.xsession
    echo "        touch /tmp/noRestartXBMC" >> /home/xbmc/.xsession
    echo "        sudo halt ;;"  >>  /home/xbmc/.xsession
    echo "    65 ) # Warm Reboot"  >>  /home/xbmc/.xsession
    echo "        echo "Restarting XBMC ..." ;;"  >>  /home/xbmc/.xsession
    echo "    66 ) # Reboot System"  >>  /home/xbmc/.xsession
    echo "        touch /tmp/noRestartXBMC" >> /home/xbmc/.xsession
    echo "        sudo reboot ;;"  >>  /home/xbmc/.xsession
    echo "     * ) ;;"  >>  /home/xbmc/.xsession
    echo "esac"  >>  /home/xbmc/.xsession

    chown xbmc:xbmc /home/xbmc/.xsession

    if [ "$(whoami)" == "root" ] ; then
        su xbmc -c "startx -- -br > /dev/null 2>&1" -l
    else
        startx -- -br > /dev/null 2>&1
    fi

    if [ -e /tmp/noRestartXBMC ] ; then
        rm -f /tmp/noRestartXBMC
        rm -f /home/xbmc/.xsession
        break
    fi

#   sleep 2
done

as you can see I also added sudo halt and sudo reboot instead
of the sleep. To make this working the following two lines are
needed in sudoers file:
xbmc            ALL=(root) NOPASSWD:/sbin/halt
xbmc            ALL=(root) NOPASSWD:/sbin/reboot

I guess this should not be a default setting, but you could give a
hint in /usr/share/doc/xbmc/README.Debian

 * Apart from this can you update revision 22503, which adds support
   for TV shows with absolute numbering?

P.S.: thanks for the great work :)

-- Sebastian Reichel

signature.asc
Description: Digital signature