Control: tags -1 fixed-upstream > On 5 Dec 2016, at 12:49, Micha vor dem Berge > <micha.vordembe...@christmann.info> wrote: >> Am 05.12.2016 um 12:27 schrieb James Clarke: >> Package: xserver-xorg-video-intel >> Version: 2:2.99.917+git20161105-1 >> Severity: important >> Tags: patch upstream >> Control: retitle -1 segfaults due to missing NULL check in >> has_connector_backlight >> >>> On 5 Dec 2016, at 10:25, Micha vor dem Berge >>> <micha.vordembe...@christmann.info> wrote: >>> >>> Hi all, >>> >>> >>> I recently upgraded my xserver-xorg-video-intel package to the newest >>> jessie-backports (version 2:2.99.917+git20161105-1~bpo8+1). After a reboot, >>> X doesn't start anymore. I used this package from backports for several >>> months, so the newest update must have caused the trouble, I think. >>> >>> After a downgrade to jessie stable (version 2:2.21.15-2+b2) X is starting >>> fine again, but I have no HW acceleration... :( >>> >>> >>> Please find attached the Xorg.log. >>> >>> Just for information: I'm using Linux Mint Debian Edition, so my desktop is >>> Cinnamon. And I compiled my own kernel (which was no problem in the past). >>> I also tried some of my older kernels of the 4.8.x kernel series - just to >>> be sure that the problem is not introduced by the newest kernel upgrade. >>> >>> >>> Best regards, >>> >>> Micha >>> >>> >>> >>> PS: Please keep me in the loop when discussing this error as I didn't >>> subscribe to the backports mailing-list. Thanks! >>> <Xorg.0.log.old> >> >> >> This looks like [1] was reached with dir being NULL, though since you don't >> have debugging symbols (and I don't know/can't seem to work out what address >> intel_drv.so was loaded at) I can't know for sure. Having said that, this is >> the only place where the result of readdir is not checked for NULL, so I >> don't >> know how else this would happen. This bug was introduced by [2]. Can you >> please >> try the attached patch? Whether or not this is the problem, I'll forward it >> upstream. >> >> Regards, >> James >> >> [1] >> https://sources.debian.net/src/xserver-xorg-video-intel/2:2.99.917%2Bgit20161105-1%7Ebpo8%2B1/src/sna/sna_display.c/#L1036 >> [2] >> https://cgit.freedesktop.org/xorg/driver/xf86-video-intel/commit/325570e731b5819e28ce6bae72242914bb2d7f8e > > I can confirm that this patch > > https://lists.x.org/archives/xorg-devel/2016-December/051958.html > > solves the problem! :-)
This has now been merged upstream[1]. Regards, James [1] https://cgit.freedesktop.org/xorg/driver/xf86-video-intel/commit/?id=a1b39eb6dd1717501a0546275d07df8321fe4905