Package: libxfce4util-dev
Version: 4.18.1-1
Severity: serious
Tags: ftbfs patch
Justification: fails to build from source (but built successfully in the past)

Dear Maintainer,

to repeat the problem, please follow these steps:

$ sudo apt install valac
$ apt-get source libxfce4util-dev
$ cd libxfce4util-4.18.1/
$ dpkg-buildpackage -j`nproc`

Output:
===================================================================================================================
...
   dh_missing
dh_missing: warning: usr/share/vala/vapi/libxfce4util-1.0.vapi exists in 
debian/tmp but is not installed to anywhere 
        The following debhelper tools have reported what they installed (with 
files per package)
         * dh_install: gir1.2-libxfce4util-1.0 (1), libxfce4util-bin (1), 
libxfce4util-common (1), libxfce4util-dev (38), libxfce4util7 (2)
         * dh_installdocs: gir1.2-libxfce4util-1.0 (0), libxfce4util-bin (0), 
libxfce4util-common (0), libxfce4util-dev (1), libxfce4util7 (0)
         * dh_installman: gir1.2-libxfce4util-1.0 (0), libxfce4util-bin (1), 
libxfce4util-common (0), libxfce4util-dev (0), libxfce4util7 (0)
        If the missing files are installed by another tool, please file a bug 
against it.
        When filing the report, if the tool is not part of debhelper itself, 
please reference the
        "Logging helpers and dh_missing" section from the "PROGRAMMING" guide 
for debhelper (10.6.3+).
          (in the debhelper package: /usr/share/doc/debhelper/PROGRAMMING.gz)
        Be sure to test with dpkg-buildpackage -A/-B as the results may vary 
when only a subset is built
        If the omission is intentional or no other helper can take care of this 
consider adding the
        paths to debian/not-installed.
dh_missing: error: missing files, aborting
make: *** [debian/rules:22: binary] Error 255
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
===================================================================================================================

To fix the issue I propose including valac to package build dependencies
and include vala api file to libxfce4util-dev.

This vala api file is useful when you wish to build some xfce plugins
from vala sources. One example is xfce4-notes-plugin which I was trying
to build and found that some vala api files are missing in Debian
distribution.

Possible fix follows.
===================================================================================================================
diff -Naur libxfce4util-4.18.1-orig/debian/control 
libxfce4util-4.18.1/debian/control
--- libxfce4util-4.18.1-orig/debian/control 2023-01-12 10:28:40.000000000 +0300
+++ libxfce4util-4.18.1/debian/control  2023-02-26 04:31:58.179657805 +0300
@@ -9,6 +9,7 @@
                intltool,
                libgirepository1.0-dev,
                libglib2.0-dev,
+               valac,
                xfce4-dev-tools
 Rules-Requires-Root: no
 Standards-Version: 4.6.2
diff -Naur libxfce4util-4.18.1-orig/debian/libxfce4util-dev.install 
libxfce4util-4.18.1/debian/libxfce4util-dev.install
--- libxfce4util-4.18.1-orig/debian/libxfce4util-dev.install    2022-12-05 
09:48:34.000000000 +0300
+++ libxfce4util-4.18.1/debian/libxfce4util-dev.install 2023-02-26 
04:27:37.163908152 +0300
@@ -3,3 +3,4 @@
 usr/lib/*/pkgconfig/*
 usr/share/gir-1.0/*
 usr/share/gtk-doc/html/libxfce4util/*
+usr/share/vala/vapi/*
===================================================================================================================

-- System Information:
Debian Release: bookworm/sid
  APT prefers testing
  APT policy: (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-3-amd64 (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8), 
LANGUAGE=ru_RU:ru
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages libxfce4util-dev depends on:
ii  gir1.2-libxfce4util-1.0  4.18.1-1
ii  libglib2.0-dev           2.74.5-1
ii  libxfce4util7            4.18.1-1

libxfce4util-dev recommends no packages.

Versions of packages libxfce4util-dev suggests:
pn  devhelp  <none>

-- no debconf information

Reply via email to