On Sun, Aug 7, 2011 at 6:33 PM, Emmanuel Lecharny <[email protected]> wrote: > On 8/7/11 10:25 AM, Mohammad Nour El-Din wrote: >> >> On Sat, Aug 6, 2011 at 8:16 AM, Julien Vermillard<[email protected]> >> wrote: >>> >>> On Fri, Aug 5, 2011 at 10:40 PM, Emmanuel Lecharny<[email protected]> >>> wrote: >>>> >>>> On 8/5/11 9:04 PM, Johnathan Meehan wrote: >>>>> >>>>> Hi, >>>>> >>>>> When I was finalising the initial implementation of DEFT-142 (Dynamic >>>>> Handlers), Mockito was added as a dependency. We had discussed using >>>>> this as a mocking framework prior to the move to Apache. >>>>> >>>>> I'm mailing the group so that we are all aware, and to be sure that: >>>>> >>>>> - it is acceptable to use the product, which is under an MIT licence. >>>> >>>> MIT license is compatible with ASL 2.0. We can use libs under MIT >>>> license : >>>> >>>> http://www.apache.org/legal/3party.html#category-a >>>> >>> Also it's just a test dependency. >> >> In that case it does not really matter as long as we are not going to >> distribute it with Deft releases. > > To be clear : as soon as it's a compatible license, we can do whatever we > want (distribute it or not). > > The fact that it's used for tests only, so they are not released, does not > matter too much. What is important is the type of library used : if we were > to use LGPL libs, for instance, then the simple fact of using such libs > would be an issue, simply because LGPL is contaminating, and we should not > let DEFT's users be contaminated without any notice. > > I mention that as we *may* use LGPL licensed libs, but in that case, we > *have* to inform DEFT's users they have to explicitly download themselves > the LGPL lib. We can't simply add a dependency and let the build system deal > with it without asking the users if they are aware of such a dependency.
Good point, mentioning that is a MUST, but I was pointing out that it is not a release blocker issue as long as: 1- It is is only used for tests. 2- It is not distributed with our releases. Correct me if I am wrong please :). > > > -- > Regards, > Cordialement, > Emmanuel Lécharny > www.iktek.com > > -- Thanks - Mohammad Nour Author of (WebSphere Application Server Community Edition 2.0 User Guide) http://www.redbooks.ibm.com/abstracts/sg247585.html - LinkedIn: http://www.linkedin.com/in/mnour - Blog: http://tadabborat.blogspot.com ---- "Life is like riding a bicycle. To keep your balance you must keep moving" - Albert Einstein "Writing clean code is what you must do in order to call yourself a professional. There is no reasonable excuse for doing anything less than your best." - Clean Code: A Handbook of Agile Software Craftsmanship "Stay hungry, stay foolish." - Steve Jobs
