On 12-10-02 10:26 PM, Michael Terry wrote: > Michael Terry has proposed merging lp:~mterry/deja-dup/libsecret into > lp:deja-dup. > > Requested reviews: > Robert Bruce Park (robru)
Hey michael, sorry I didn't get to this sooner, I've been a bit swamped and it must have gotten buried in the inbox. I tried to ping you on IRC but you weren't there. I'll read over this for now, but I'll need a bit of guidance with interactive testing to make sure it does what you say it does. Just ping me whenever you get back on IRC. > I tested manually that it works (and finds old passwords saved with > libgnome-keyring). Didn't seem easy or worth it to add unit tests for an > inherently integration-oriented branch like this. Yeah, the code all looks relatively straightforward. Like I said, just ping me and tell me what steps to take to test this and then I'll approve it. -- https://code.launchpad.net/~mterry/deja-dup/libsecret/+merge/127627 Your team Déjà Dup Developers is subscribed to branch lp:deja-dup. _______________________________________________ Mailing list: https://launchpad.net/~deja-dup-team Post to : [email protected] Unsubscribe : https://launchpad.net/~deja-dup-team More help : https://help.launchpad.net/ListHelp
