Review: Approve

No, this looks good.  I was just hesitant to add support for something called 
"Google Cloud Storage" which will be confusing next to "Google Drive" when we 
flip the switch to enable that.  But if Google is OK with it...  Plus, when we 
do that, maybe we can add a label like "only for advanced users" or some such 
thing to make it clearer.  As if asking for a "bucket" and "secret access key" 
isn't intimidating enough.

As for why Google Drive support isn't finished, it's because at the time, 
Duplicity's Google Drive plugin was a bit in flux.  The API it used was about 
to be deprecated by Google, and I was waiting for that to settle.  It probably 
has now...  I need to look at that.  But the code is all there in deja-dup, 
just hidden from the UI for now.

But this branch as-is is fine, thank you!  Sorry for the long delay.  I'll 
probably move your credit in AUTHORS into the main block at the top, but that's 
it.  Thanks!
-- 
https://code.launchpad.net/~mwrius/deja-dup/GCS/+merge/276188
Your team Déjà Dup Developers is subscribed to branch lp:deja-dup.

_______________________________________________
Mailing list: https://launchpad.net/~deja-dup-team
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~deja-dup-team
More help   : https://help.launchpad.net/ListHelp

Reply via email to