On Mon, 2010-09-20 at 13:35 -0400, Chris Lalancette wrote: > On 09/10/10 - 04:44:09PM, David Lutterkort wrote: > > On Thu, 2010-09-09 at 15:30 -0400, Chris Lalancette wrote: > > > For some drivers, we were passing the raw string we got from > > > the cloud provider through as the instance state. However, > > > that doesn't fit in with trying to make the drivers act consistent, > > > so make sure all of the drivers have a translation layer between > > > the cloud provider's states and the deltcloud API states. > > > > ACK to the patch; stylistically, it would be more rubyish if states were > > symbols internally, but that'll be a battle for another day. > > Yeah, I actually tried to make them symbols at first, but it blew up in my > face. I'm not quite sure why; it's probably some misunderstanding I have > about > symbols in Ruby, but as you say, it's a minor optimization we can do later. > > Can either you or Michal push this patch for me? I still don't have commit > access.
Keep forgetting that, just pushed the patch. We should make you the guinea pig for the 'new committer' process ;) David
