On Sun, 2011-03-06 at 22:09 +0100, Michal Fojtik wrote: > On Mar 5, 2011, at 1:40 AM, David Lutterkort wrote: > > > On Fri, 2011-03-04 at 12:59 +0100, [email protected] wrote: > >> From: Michal Fojtik <[email protected]> > >> > >> --- > >> .../lib/deltacloud/helpers/application_helper.rb | 10 ++++- > >> server/server.rb | 40 > >> ++++++++++++++++--- > >> server/tests/drivers/mock/instances_test.rb | 6 +-- > >> 3 files changed, 42 insertions(+), 14 deletions(-) > > > > ACK. A few comments: > > > >> diff --git a/server/lib/deltacloud/helpers/application_helper.rb > >> b/server/lib/deltacloud/helpers/application_helper.rb > >> index 191a0c9..e7725dd 100644 > >> --- a/server/lib/deltacloud/helpers/application_helper.rb > >> +++ b/server/lib/deltacloud/helpers/application_helper.rb > >> @@ -126,7 +126,13 @@ module ApplicationHelper > >> > >> @instance = driver.send(:"#{name}_instance", credentials, params["id"]) > >> > >> - return redirect(instances_url) if name.eql?(:destroy) or > >> @instance.class!=Instance > >> + if name.eql?(:destroy) or @instance.class!=Instance > > > > It was there in the original code - any idea what the '@instance.class ! > > = Instance' is all about ? > > No idea after half year ;-) But git blame says: > > 6ce87b83 server/lib/deltacloud/helpers/application_helper.rb (lutter > 2010-07-08 23:48:39 +0000 129) return redirect(instances_url) if > name.eql?(:destroy) or @instance.class!=Instance > > :-))
Hah .. that should teach me to ask before running git blame David
