Thanks David. Do you want me to re-generate a patch with the exceptions added? Or should I wait until the previous one and this one is committed, and then generates new one?
Sang-min -----Original Message----- From: David Lutterkort [mailto:[email protected]] Sent: Monday, March 21, 2011 4:50 PM To: [email protected] Cc: [email protected]; Sang-Min Park Subject: Re: [PATCH] Eucalyptus driver support On Thu, 2011-03-10 at 15:27 -0800, [email protected] wrote: > From: Sang-Min Park <[email protected]> This looks good, but might need some reshuffling once the previous patch has been changed to address the comments. One minor thing that I'd like to see changed: > diff --git > a/server/lib/deltacloud/drivers/eucalyptus/eucalyptus_driver.rb > b/server/lib/deltacloud/drivers/eucalyptus/eucalyptus_driver.rb > new file mode 100644 > index 0000000..52d4c67 > --- /dev/null > +++ b/server/lib/deltacloud/drivers/eucalyptus/eucalyptus_driver.rb > + def tag_instance(credentials, instance, name) > + # dummy > + end > + > + def untag_instance(credentials, instance_id) > + # dummy > + end > + > + # because load balancer is not on the supported_collections, > + # the following methods shouldn't be called. > + def load_balancer(credentials, opts={}) > + return nil > + end > + > + def load_balancers(credentials, opts=nil) > + return [] > + end All the methods that should never be called should fail very noisily if they do get called by mistake; they should all raise a BackendError. David
