On Wed, 2011-06-08 at 20:09 +0300, [email protected] wrote:
> From: marios <[email protected]>
>
>
> Signed-off-by: marios <[email protected]>
> ---
> server/lib/deltacloud/drivers/ec2/ec2_driver.rb | 37 ++++++-
> server/lib/deltacloud/helpers/blob_stream.rb | 142
> ++++++++++++++++++++++-
> server/server.rb | 51 +++++++--
> server/views/blobs/new.html.haml | 14 +-
> 4 files changed, 220 insertions(+), 24 deletions(-)
ACK. One small thing below; it's fine to just fix it and push without
posting the patches again.
> diff --git a/server/lib/deltacloud/drivers/ec2/ec2_driver.rb
> b/server/lib/deltacloud/drivers/ec2/ec2_driver.rb
> index 4edd989..d37e8ab 100644
> --- a/server/lib/deltacloud/drivers/ec2/ec2_driver.rb
> +++ b/server/lib/deltacloud/drivers/ec2/ec2_driver.rb
>
> @@ -445,6 +445,40 @@ module Deltacloud
> end
> end
>
> + #params:
> {:user,:password,:bucket,:blob,:content_type,:content_length,:metadata}
> + def blob_stream_connection(params)
> + #canonicalise metadata:
> +
> #http://docs.amazonwebservices.com/AmazonS3/latest/dev/index.html?RESTAuthentication.html
> + metadata = params[:metadata]
If you write 'metadata = params[:metadata] || {}' you don't need the
various 'unless metadata.nil?', which makes the code more readable.
David
