On Wed, 2011-07-13 at 12:04 +0200, [email protected] wrote: > From: Michal Fojtik <[email protected]> > > > Signed-off-by: Michal fojtik <[email protected]>
ACK. One nit: > diff --git a/server/lib/deltacloud/drivers/vsphere/vsphere_driver.rb > b/server/lib/deltacloud/drivers/vsphere/vsphere_driver.rb > index 64bfa34..81b5a85 100644 > --- a/server/lib/deltacloud/drivers/vsphere/vsphere_driver.rb > +++ b/server/lib/deltacloud/drivers/vsphere/vsphere_driver.rb > @@ -257,9 +257,12 @@ module Deltacloud::Drivers::VSphere > # Destroy an instance, given its id. Note that this will destory all > # instance data. > def destroy_instance(credentials, id) > + id = id[:id] if id.class == Hash We should have one calling convention for this - either always pass in a hash or always pass in just the id. David
