very nice ACK

BUT... minor copy/paste error in POST /api/buckets/:bucket/:blob (now operation :create in blobs subcollection), parameter for blob name is 'params[blob_id]' (you have 'params[blob]') so it gives an error

also couple cosmetic issues ... description of destroy blob is 'destroy bucket', description of put blob (:stream) is 'get blob metadata'

please fix before push (especially the first one with param name)

marios

On 15/09/11 12:18, [email protected] wrote:
Hi,

This is the second revision of 'subcollections' patch for rabbit.
In addition to previous patch this:

1. Rename 'subcollection' helper method to just 'collection' so:

collection :buckets do
   collection :blobs do
   end
end

2. Fully rebased against current master

   -- Michal


Reply via email to